You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Santiago Gala <sa...@gmail.com> on 2008/05/07 09:31:04 UTC
Whitespace cleanup
http://people.apache.org/~sgala/git/?p=shindig.git;a=commitdiff;h=220e922e4ad455414c98b1dc298e191c92fa5dc7
lists a big diff that would cleanup the following conditions:
- whitespace (blanks or tabs) before EOL [1]
- spaces before tabs in indentation
I won't commit something that intrusive to the main line of development,
as it would be likely to cause lots of conflicts for no clear reason
Not a biggie, just in case people wans to clean up this kind of things
before starting work on those files, etc.
I could actually commit this, but I won't do without a clear permission,
as it is very likely to conflict a lot. I have been doing the exercise
every so and so, and the number of "affected" files does not seem to be
going down, rather the opposite. I don't open an issue with the patch
because the patch changes too often to be really useful.
Regards
Santiago
[1] I'm not so sure that a space before EOL is really evil in plain
text, but a number of tools bark on it anyhow. I think spaces before
tabs should be cleaned, that would be a way minor patch.
--
Santiago Gala
http://memojo.com/~sgala/blog/
Re: Whitespace cleanup
Posted by Kevin Brown <et...@google.com>.
On Thu, May 8, 2008 at 1:03 AM, Cassie <do...@apache.org> wrote:
> yeah, chris already fixed all his stuff and the php is all good now.
>
> kevin - do you think you could just double check your editor and fix all
> the
> java/gadgets files w/santiago's patch?
> if we do that then all the code will be clean.
I can run through everything, but I'll do that as I migrate the common stuff
out of gadgets and into, er, "common". I'm working on that now.
> as for patches with whitespace. yeah, i have been seeing a lot of those. i
> typically try to open them up in my ide to have it fix any out of order
> imports, whitespace, tabs etc before checking it in. i think getting the
> eclipse styles in will definitely help this.
>
>
> - cassie
>
>
> On Wed, May 7, 2008 at 7:16 PM, Kevin Brown <et...@google.com> wrote:
>
> > On Wed, May 7, 2008 at 8:26 AM, Santiago Gala <sa...@gmail.com>
> > wrote:
> >
> > > Conventions are not that important, but their main aim is to create
> > > community by making easy to understand and modify the existing code,
> > > and also to avoid gratuitous diffs when different editors open the
> > > files. I'm not sure if we have those code conventions written, though
> > > the eclipse settings go a way towards it. Typically in the java world
> > > people does not use tabs, while the PHP world is much more akin to
> > > them. Not sure about javascript, or what eclipse does WRT tabs and
> > > spaces, etc.
> >
> >
> > Using tabs in PHP code isn't very common, actually (I've been involved
> with
> > a lot of PHP-based organizations, and none of them have ever allowed
> tabs).
> > I'm surprised that Zend does this, though if it's eclipsed based you can
> > probably change it to use spaces instead of tabs anyway.
> >
> > The biggest whitespace culprits so far have been applying patches from
> > other
> > contributors. I haven't seen many (any?) tabs, but I've seen lots of
> > trailing whitespace.
> >
> >
> > >
> > > A lot of different cultures are merging in shindig :)
> > >
> > > Regards
> > > Santiago
> > >
> > > On Wed, May 7, 2008 at 4:16 PM, Chris Chabot <ch...@xs4all.nl>
> wrote:
> > > > Ok tweaked eclipse a bit, re-formated the whole thing to remove the
> > > > whitespace before EOL's, should be all good on the PHP side now
> > > >
> > > > ref: http://svn.apache.org/viewvc?view=rev&revision=654115
> > > >
> > > > -- Chris
> > > >
> > > >
> > > >
> > > > On May 7, 2008, at 12:50 PM, Chris Chabot wrote:
> > > >
> > > >
> > > > > No fair ! :-)
> > > > >
> > > > > if you look at the php patches it's all:
> > > > > - <tab>
> > > > > +<nothing>
> > > > >
> > > > > between class functions.
> > > > >
> > > > > Zend studio for eclipse puts indentation between class functions,
> so
> > > that
> > > > when you start typing your new function there, it's in the right spot
> > > right
> > > > away ... behavior i'm rather fond of tbh :-) But i guess i could go
> dig
> > > in
> > > > the options and see where i can turn it off if it's a problem :)
> > > > >
> > > > > -- Chris
> > > > >
> > > > > On May 7, 2008, at 12:37 PM, Cassie wrote:
> > > > >
> > > > >
> > > > > > btw - if you look at santiago's diff the social-api stuff is 99%
> > > clean.
> > > > > > kevin, louis and chris - i think you need to fix your IDEs :)
> > > > > >
> > > > > >
> > > > > > On Wed, May 7, 2008 at 9:31 AM, Santiago Gala <
> > > santiago.gala@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > >
> > > > > > >
> > > > > > >
> > > >
> > >
> >
> http://people.apache.org/~sgala/git/?p=shindig.git;a=commitdiff;h=220e922e4ad455414c98b1dc298e191c92fa5dc7<http://people.apache.org/%7Esgala/git/?p=shindig.git;a=commitdiff;h=220e922e4ad455414c98b1dc298e191c92fa5dc7>
> <
> http://people.apache.org/%7Esgala/git/?p=shindig.git;a=commitdiff;h=220e922e4ad455414c98b1dc298e191c92fa5dc7
> >
> > <
> >
> http://people.apache.org/%7Esgala/git/?p=shindig.git;a=commitdiff;h=220e922e4ad455414c98b1dc298e191c92fa5dc7
> > >
> > > <
> > >
> >
> http://people.apache.org/%7Esgala/git/?p=shindig.git;a=commitdiff;h=220e922e4ad455414c98b1dc298e191c92fa5dc7
> > > >
> > > > > > >
> > > > > > > lists a big diff that would cleanup the following conditions:
> > > > > > >
> > > > > > > - whitespace (blanks or tabs) before EOL [1]
> > > > > > > - spaces before tabs in indentation
> > > > > > >
> > > > > > > I won't commit something that intrusive to the main line of
> > > > development,
> > > > > > > as it would be likely to cause lots of conflicts for no clear
> > > reason
> > > > > > >
> > > > > > > Not a biggie, just in case people wans to clean up this kind of
> > > things
> > > > > > > before starting work on those files, etc.
> > > > > > >
> > > > > > > I could actually commit this, but I won't do without a clear
> > > > permission,
> > > > > > > as it is very likely to conflict a lot. I have been doing the
> > > exercise
> > > > > > > every so and so, and the number of "affected" files does not
> seem
> > > to
> > > > be
> > > > > > > going down, rather the opposite. I don't open an issue with the
> > > patch
> > > > > > > because the patch changes too often to be really useful.
> > > > > > >
> > > > > > > Regards
> > > > > > > Santiago
> > > > > > >
> > > > > > > [1] I'm not so sure that a space before EOL is really evil in
> > > plain
> > > > > > > text, but a number of tools bark on it anyhow. I think spaces
> > > before
> > > > > > > tabs should be cleaned, that would be a way minor patch.
> > > > > > > --
> > > > > > > Santiago Gala
> > > > > > > http://memojo.com/~sgala/blog/<http://memojo.com/%7Esgala/blog/>
> <http://memojo.com/%7Esgala/blog/><
> > http://memojo.com/%7Esgala/blog/><
> > > http://memojo.com/%7Esgala/blog/>
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > > >
> > >
> >
>
Re: Whitespace cleanup
Posted by Cassie <do...@apache.org>.
yeah, chris already fixed all his stuff and the php is all good now.
kevin - do you think you could just double check your editor and fix all the
java/gadgets files w/santiago's patch?
if we do that then all the code will be clean.
as for patches with whitespace. yeah, i have been seeing a lot of those. i
typically try to open them up in my ide to have it fix any out of order
imports, whitespace, tabs etc before checking it in. i think getting the
eclipse styles in will definitely help this.
- cassie
On Wed, May 7, 2008 at 7:16 PM, Kevin Brown <et...@google.com> wrote:
> On Wed, May 7, 2008 at 8:26 AM, Santiago Gala <sa...@gmail.com>
> wrote:
>
> > Conventions are not that important, but their main aim is to create
> > community by making easy to understand and modify the existing code,
> > and also to avoid gratuitous diffs when different editors open the
> > files. I'm not sure if we have those code conventions written, though
> > the eclipse settings go a way towards it. Typically in the java world
> > people does not use tabs, while the PHP world is much more akin to
> > them. Not sure about javascript, or what eclipse does WRT tabs and
> > spaces, etc.
>
>
> Using tabs in PHP code isn't very common, actually (I've been involved with
> a lot of PHP-based organizations, and none of them have ever allowed tabs).
> I'm surprised that Zend does this, though if it's eclipsed based you can
> probably change it to use spaces instead of tabs anyway.
>
> The biggest whitespace culprits so far have been applying patches from
> other
> contributors. I haven't seen many (any?) tabs, but I've seen lots of
> trailing whitespace.
>
>
> >
> > A lot of different cultures are merging in shindig :)
> >
> > Regards
> > Santiago
> >
> > On Wed, May 7, 2008 at 4:16 PM, Chris Chabot <ch...@xs4all.nl> wrote:
> > > Ok tweaked eclipse a bit, re-formated the whole thing to remove the
> > > whitespace before EOL's, should be all good on the PHP side now
> > >
> > > ref: http://svn.apache.org/viewvc?view=rev&revision=654115
> > >
> > > -- Chris
> > >
> > >
> > >
> > > On May 7, 2008, at 12:50 PM, Chris Chabot wrote:
> > >
> > >
> > > > No fair ! :-)
> > > >
> > > > if you look at the php patches it's all:
> > > > - <tab>
> > > > +<nothing>
> > > >
> > > > between class functions.
> > > >
> > > > Zend studio for eclipse puts indentation between class functions, so
> > that
> > > when you start typing your new function there, it's in the right spot
> > right
> > > away ... behavior i'm rather fond of tbh :-) But i guess i could go dig
> > in
> > > the options and see where i can turn it off if it's a problem :)
> > > >
> > > > -- Chris
> > > >
> > > > On May 7, 2008, at 12:37 PM, Cassie wrote:
> > > >
> > > >
> > > > > btw - if you look at santiago's diff the social-api stuff is 99%
> > clean.
> > > > > kevin, louis and chris - i think you need to fix your IDEs :)
> > > > >
> > > > >
> > > > > On Wed, May 7, 2008 at 9:31 AM, Santiago Gala <
> > santiago.gala@gmail.com>
> > > > > wrote:
> > > > >
> > > > >
> > > > > >
> > > > > >
> > >
> >
> http://people.apache.org/~sgala/git/?p=shindig.git;a=commitdiff;h=220e922e4ad455414c98b1dc298e191c92fa5dc7<http://people.apache.org/%7Esgala/git/?p=shindig.git;a=commitdiff;h=220e922e4ad455414c98b1dc298e191c92fa5dc7>
> <
> http://people.apache.org/%7Esgala/git/?p=shindig.git;a=commitdiff;h=220e922e4ad455414c98b1dc298e191c92fa5dc7
> >
> > <
> >
> http://people.apache.org/%7Esgala/git/?p=shindig.git;a=commitdiff;h=220e922e4ad455414c98b1dc298e191c92fa5dc7
> > >
> > > > > >
> > > > > > lists a big diff that would cleanup the following conditions:
> > > > > >
> > > > > > - whitespace (blanks or tabs) before EOL [1]
> > > > > > - spaces before tabs in indentation
> > > > > >
> > > > > > I won't commit something that intrusive to the main line of
> > > development,
> > > > > > as it would be likely to cause lots of conflicts for no clear
> > reason
> > > > > >
> > > > > > Not a biggie, just in case people wans to clean up this kind of
> > things
> > > > > > before starting work on those files, etc.
> > > > > >
> > > > > > I could actually commit this, but I won't do without a clear
> > > permission,
> > > > > > as it is very likely to conflict a lot. I have been doing the
> > exercise
> > > > > > every so and so, and the number of "affected" files does not seem
> > to
> > > be
> > > > > > going down, rather the opposite. I don't open an issue with the
> > patch
> > > > > > because the patch changes too often to be really useful.
> > > > > >
> > > > > > Regards
> > > > > > Santiago
> > > > > >
> > > > > > [1] I'm not so sure that a space before EOL is really evil in
> > plain
> > > > > > text, but a number of tools bark on it anyhow. I think spaces
> > before
> > > > > > tabs should be cleaned, that would be a way minor patch.
> > > > > > --
> > > > > > Santiago Gala
> > > > > > http://memojo.com/~sgala/blog/<http://memojo.com/%7Esgala/blog/><
> http://memojo.com/%7Esgala/blog/><
> > http://memojo.com/%7Esgala/blog/>
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> > >
> >
>
Re: Whitespace cleanup
Posted by Kevin Brown <et...@google.com>.
On Wed, May 7, 2008 at 8:26 AM, Santiago Gala <sa...@gmail.com>
wrote:
> Conventions are not that important, but their main aim is to create
> community by making easy to understand and modify the existing code,
> and also to avoid gratuitous diffs when different editors open the
> files. I'm not sure if we have those code conventions written, though
> the eclipse settings go a way towards it. Typically in the java world
> people does not use tabs, while the PHP world is much more akin to
> them. Not sure about javascript, or what eclipse does WRT tabs and
> spaces, etc.
Using tabs in PHP code isn't very common, actually (I've been involved with
a lot of PHP-based organizations, and none of them have ever allowed tabs).
I'm surprised that Zend does this, though if it's eclipsed based you can
probably change it to use spaces instead of tabs anyway.
The biggest whitespace culprits so far have been applying patches from other
contributors. I haven't seen many (any?) tabs, but I've seen lots of
trailing whitespace.
>
> A lot of different cultures are merging in shindig :)
>
> Regards
> Santiago
>
> On Wed, May 7, 2008 at 4:16 PM, Chris Chabot <ch...@xs4all.nl> wrote:
> > Ok tweaked eclipse a bit, re-formated the whole thing to remove the
> > whitespace before EOL's, should be all good on the PHP side now
> >
> > ref: http://svn.apache.org/viewvc?view=rev&revision=654115
> >
> > -- Chris
> >
> >
> >
> > On May 7, 2008, at 12:50 PM, Chris Chabot wrote:
> >
> >
> > > No fair ! :-)
> > >
> > > if you look at the php patches it's all:
> > > - <tab>
> > > +<nothing>
> > >
> > > between class functions.
> > >
> > > Zend studio for eclipse puts indentation between class functions, so
> that
> > when you start typing your new function there, it's in the right spot
> right
> > away ... behavior i'm rather fond of tbh :-) But i guess i could go dig
> in
> > the options and see where i can turn it off if it's a problem :)
> > >
> > > -- Chris
> > >
> > > On May 7, 2008, at 12:37 PM, Cassie wrote:
> > >
> > >
> > > > btw - if you look at santiago's diff the social-api stuff is 99%
> clean.
> > > > kevin, louis and chris - i think you need to fix your IDEs :)
> > > >
> > > >
> > > > On Wed, May 7, 2008 at 9:31 AM, Santiago Gala <
> santiago.gala@gmail.com>
> > > > wrote:
> > > >
> > > >
> > > > >
> > > > >
> >
> http://people.apache.org/~sgala/git/?p=shindig.git;a=commitdiff;h=220e922e4ad455414c98b1dc298e191c92fa5dc7<http://people.apache.org/%7Esgala/git/?p=shindig.git;a=commitdiff;h=220e922e4ad455414c98b1dc298e191c92fa5dc7>
> <
> http://people.apache.org/%7Esgala/git/?p=shindig.git;a=commitdiff;h=220e922e4ad455414c98b1dc298e191c92fa5dc7
> >
> > > > >
> > > > > lists a big diff that would cleanup the following conditions:
> > > > >
> > > > > - whitespace (blanks or tabs) before EOL [1]
> > > > > - spaces before tabs in indentation
> > > > >
> > > > > I won't commit something that intrusive to the main line of
> > development,
> > > > > as it would be likely to cause lots of conflicts for no clear
> reason
> > > > >
> > > > > Not a biggie, just in case people wans to clean up this kind of
> things
> > > > > before starting work on those files, etc.
> > > > >
> > > > > I could actually commit this, but I won't do without a clear
> > permission,
> > > > > as it is very likely to conflict a lot. I have been doing the
> exercise
> > > > > every so and so, and the number of "affected" files does not seem
> to
> > be
> > > > > going down, rather the opposite. I don't open an issue with the
> patch
> > > > > because the patch changes too often to be really useful.
> > > > >
> > > > > Regards
> > > > > Santiago
> > > > >
> > > > > [1] I'm not so sure that a space before EOL is really evil in
> plain
> > > > > text, but a number of tools bark on it anyhow. I think spaces
> before
> > > > > tabs should be cleaned, that would be a way minor patch.
> > > > > --
> > > > > Santiago Gala
> > > > > http://memojo.com/~sgala/blog/ <http://memojo.com/%7Esgala/blog/><
> http://memojo.com/%7Esgala/blog/>
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
> >
>
Re: Whitespace cleanup
Posted by Santiago Gala <sa...@gmail.com>.
Conventions are not that important, but their main aim is to create
community by making easy to understand and modify the existing code,
and also to avoid gratuitous diffs when different editors open the
files. I'm not sure if we have those code conventions written, though
the eclipse settings go a way towards it. Typically in the java world
people does not use tabs, while the PHP world is much more akin to
them. Not sure about javascript, or what eclipse does WRT tabs and
spaces, etc.
A lot of different cultures are merging in shindig :)
Regards
Santiago
On Wed, May 7, 2008 at 4:16 PM, Chris Chabot <ch...@xs4all.nl> wrote:
> Ok tweaked eclipse a bit, re-formated the whole thing to remove the
> whitespace before EOL's, should be all good on the PHP side now
>
> ref: http://svn.apache.org/viewvc?view=rev&revision=654115
>
> -- Chris
>
>
>
> On May 7, 2008, at 12:50 PM, Chris Chabot wrote:
>
>
> > No fair ! :-)
> >
> > if you look at the php patches it's all:
> > - <tab>
> > +<nothing>
> >
> > between class functions.
> >
> > Zend studio for eclipse puts indentation between class functions, so that
> when you start typing your new function there, it's in the right spot right
> away ... behavior i'm rather fond of tbh :-) But i guess i could go dig in
> the options and see where i can turn it off if it's a problem :)
> >
> > -- Chris
> >
> > On May 7, 2008, at 12:37 PM, Cassie wrote:
> >
> >
> > > btw - if you look at santiago's diff the social-api stuff is 99% clean.
> > > kevin, louis and chris - i think you need to fix your IDEs :)
> > >
> > >
> > > On Wed, May 7, 2008 at 9:31 AM, Santiago Gala <sa...@gmail.com>
> > > wrote:
> > >
> > >
> > > >
> > > >
> http://people.apache.org/~sgala/git/?p=shindig.git;a=commitdiff;h=220e922e4ad455414c98b1dc298e191c92fa5dc7<http://people.apache.org/%7Esgala/git/?p=shindig.git;a=commitdiff;h=220e922e4ad455414c98b1dc298e191c92fa5dc7>
> > > >
> > > > lists a big diff that would cleanup the following conditions:
> > > >
> > > > - whitespace (blanks or tabs) before EOL [1]
> > > > - spaces before tabs in indentation
> > > >
> > > > I won't commit something that intrusive to the main line of
> development,
> > > > as it would be likely to cause lots of conflicts for no clear reason
> > > >
> > > > Not a biggie, just in case people wans to clean up this kind of things
> > > > before starting work on those files, etc.
> > > >
> > > > I could actually commit this, but I won't do without a clear
> permission,
> > > > as it is very likely to conflict a lot. I have been doing the exercise
> > > > every so and so, and the number of "affected" files does not seem to
> be
> > > > going down, rather the opposite. I don't open an issue with the patch
> > > > because the patch changes too often to be really useful.
> > > >
> > > > Regards
> > > > Santiago
> > > >
> > > > [1] I'm not so sure that a space before EOL is really evil in plain
> > > > text, but a number of tools bark on it anyhow. I think spaces before
> > > > tabs should be cleaned, that would be a way minor patch.
> > > > --
> > > > Santiago Gala
> > > > http://memojo.com/~sgala/blog/ <http://memojo.com/%7Esgala/blog/>
> > > >
> > > >
> > > >
> > >
> >
>
>
Re: Whitespace cleanup
Posted by Chris Chabot <ch...@xs4all.nl>.
Ok tweaked eclipse a bit, re-formated the whole thing to remove the
whitespace before EOL's, should be all good on the PHP side now
ref: http://svn.apache.org/viewvc?view=rev&revision=654115
-- Chris
On May 7, 2008, at 12:50 PM, Chris Chabot wrote:
> No fair ! :-)
>
> if you look at the php patches it's all:
> - <tab>
> +<nothing>
>
> between class functions.
>
> Zend studio for eclipse puts indentation between class functions, so
> that when you start typing your new function there, it's in the
> right spot right away ... behavior i'm rather fond of tbh :-) But i
> guess i could go dig in the options and see where i can turn it off
> if it's a problem :)
>
> -- Chris
>
> On May 7, 2008, at 12:37 PM, Cassie wrote:
>
>> btw - if you look at santiago's diff the social-api stuff is 99%
>> clean.
>> kevin, louis and chris - i think you need to fix your IDEs :)
>>
>>
>> On Wed, May 7, 2008 at 9:31 AM, Santiago Gala <santiago.gala@gmail.com
>> >
>> wrote:
>>
>>>
>>> http://people.apache.org/~sgala/git/?p=shindig.git;a=commitdiff;h=220e922e4ad455414c98b1dc298e191c92fa5dc7
>>> <http://people.apache.org/%7Esgala/git/?p=shindig.git;a=commitdiff;h=220e922e4ad455414c98b1dc298e191c92fa5dc7
>>> >
>>>
>>> lists a big diff that would cleanup the following conditions:
>>>
>>> - whitespace (blanks or tabs) before EOL [1]
>>> - spaces before tabs in indentation
>>>
>>> I won't commit something that intrusive to the main line of
>>> development,
>>> as it would be likely to cause lots of conflicts for no clear reason
>>>
>>> Not a biggie, just in case people wans to clean up this kind of
>>> things
>>> before starting work on those files, etc.
>>>
>>> I could actually commit this, but I won't do without a clear
>>> permission,
>>> as it is very likely to conflict a lot. I have been doing the
>>> exercise
>>> every so and so, and the number of "affected" files does not seem
>>> to be
>>> going down, rather the opposite. I don't open an issue with the
>>> patch
>>> because the patch changes too often to be really useful.
>>>
>>> Regards
>>> Santiago
>>>
>>> [1] I'm not so sure that a space before EOL is really evil in plain
>>> text, but a number of tools bark on it anyhow. I think spaces before
>>> tabs should be cleaned, that would be a way minor patch.
>>> --
>>> Santiago Gala
>>> http://memojo.com/~sgala/blog/ <http://memojo.com/%7Esgala/blog/>
>>>
>>>
Re: Whitespace cleanup
Posted by Chris Chabot <ch...@xs4all.nl>.
No fair ! :-)
if you look at the php patches it's all:
- <tab>
+<nothing>
between class functions.
Zend studio for eclipse puts indentation between class functions, so
that when you start typing your new function there, it's in the right
spot right away ... behavior i'm rather fond of tbh :-) But i guess i
could go dig in the options and see where i can turn it off if it's a
problem :)
-- Chris
On May 7, 2008, at 12:37 PM, Cassie wrote:
> btw - if you look at santiago's diff the social-api stuff is 99%
> clean.
> kevin, louis and chris - i think you need to fix your IDEs :)
>
>
> On Wed, May 7, 2008 at 9:31 AM, Santiago Gala
> <sa...@gmail.com>
> wrote:
>
>>
>> http://people.apache.org/~sgala/git/?p=shindig.git;a=commitdiff;h=220e922e4ad455414c98b1dc298e191c92fa5dc7
>> <http://people.apache.org/%7Esgala/git/?p=shindig.git;a=commitdiff;h=220e922e4ad455414c98b1dc298e191c92fa5dc7
>> >
>>
>> lists a big diff that would cleanup the following conditions:
>>
>> - whitespace (blanks or tabs) before EOL [1]
>> - spaces before tabs in indentation
>>
>> I won't commit something that intrusive to the main line of
>> development,
>> as it would be likely to cause lots of conflicts for no clear reason
>>
>> Not a biggie, just in case people wans to clean up this kind of
>> things
>> before starting work on those files, etc.
>>
>> I could actually commit this, but I won't do without a clear
>> permission,
>> as it is very likely to conflict a lot. I have been doing the
>> exercise
>> every so and so, and the number of "affected" files does not seem
>> to be
>> going down, rather the opposite. I don't open an issue with the patch
>> because the patch changes too often to be really useful.
>>
>> Regards
>> Santiago
>>
>> [1] I'm not so sure that a space before EOL is really evil in plain
>> text, but a number of tools bark on it anyhow. I think spaces before
>> tabs should be cleaned, that would be a way minor patch.
>> --
>> Santiago Gala
>> http://memojo.com/~sgala/blog/ <http://memojo.com/%7Esgala/blog/>
>>
>>
Re: Whitespace cleanup
Posted by Cassie <do...@apache.org>.
btw - if you look at santiago's diff the social-api stuff is 99% clean.
kevin, louis and chris - i think you need to fix your IDEs :)
On Wed, May 7, 2008 at 9:31 AM, Santiago Gala <sa...@gmail.com>
wrote:
>
> http://people.apache.org/~sgala/git/?p=shindig.git;a=commitdiff;h=220e922e4ad455414c98b1dc298e191c92fa5dc7<http://people.apache.org/%7Esgala/git/?p=shindig.git;a=commitdiff;h=220e922e4ad455414c98b1dc298e191c92fa5dc7>
>
> lists a big diff that would cleanup the following conditions:
>
> - whitespace (blanks or tabs) before EOL [1]
> - spaces before tabs in indentation
>
> I won't commit something that intrusive to the main line of development,
> as it would be likely to cause lots of conflicts for no clear reason
>
> Not a biggie, just in case people wans to clean up this kind of things
> before starting work on those files, etc.
>
> I could actually commit this, but I won't do without a clear permission,
> as it is very likely to conflict a lot. I have been doing the exercise
> every so and so, and the number of "affected" files does not seem to be
> going down, rather the opposite. I don't open an issue with the patch
> because the patch changes too often to be really useful.
>
> Regards
> Santiago
>
> [1] I'm not so sure that a space before EOL is really evil in plain
> text, but a number of tools bark on it anyhow. I think spaces before
> tabs should be cleaned, that would be a way minor patch.
> --
> Santiago Gala
> http://memojo.com/~sgala/blog/ <http://memojo.com/%7Esgala/blog/>
>
>