[jira] Updated: (CAMEL-1962) Seda producer throws if queue is full

["Adam Brewster (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/activemq/browse/CAMEL-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Brewster updated CAMEL-1962:
---------------------------------

    Attachment: 0001-seda-don-t-throw-IllegalStateException.patch

Here's my attempt at a fix.

I know that there are two variables called queue in the new class, but it seemed prettier than casting.

> Seda producer throws if queue is full
> -------------------------------------
>
>                 Key: CAMEL-1962
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1962
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 1.6.1, 2.0.0
>         Environment: Java SE 5
>            Reporter: Adam Brewster
>         Attachments: 0001-seda-don-t-throw-IllegalStateException.patch
>
>   Original Estimate: 30 minutes
>  Remaining Estimate: 30 minutes
>
> The LinkedBlockingQueue used by the SedaComponent supports a couple of different ways to insert an object into the queue.
>  - Collection.add adds the element immediately if possible or throws an IllegalStateException if the queue is full
>  - BlockingQueue.offer adds the element immediately if possible or returns false if the queue is full
>  - BlockingQueue.put waits if necessary and adds the element when space is available
> SedaProducer extends CollectionProducer which holds a reference to a collection, so it has to use the add method specified by the Collection interface.
> I suggest that either of the BlockingQueue methods would be superior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.