[jira] [Commented] (AIRFLOW-4557) The get_sqlproxy_runner() method of the CloudSqlDatabaseHook requires you to use the google_cloud_default_connection

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846200#comment-16846200 ] 

ASF GitHub Bot commented on AIRFLOW-4557:
-----------------------------------------

andrewhharmon commented on pull request #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner
URL: https://github.com/apache/airflow/pull/5314
 
 
   ### Jira
   
   - [x] My PR addresses the following [AIRFLOW-4557](https://issues.apache.org/jira/browse/AIRFLOW-4557)
   
   ### Description
   
   - [x] The get_sqlproxy_runner method of the CloudSqlDatabaseHook did not pass in the gcp_conn_id when creating an instance of the CloudSqlProxyRunner. This meant that the  always used the `google_cloud_default'`. Instead it should use whatever conn_id was passed into CloudSqlDatabaseHook gcp_cloudsql_conn_id parameter
   
   ### Tests
   
   - [x] My PR adds the following unit tests
   
   - test_gcp_sql_hook.test_get_sqlproxy_runner()
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] No new functionality, fixing a bug
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> The get_sqlproxy_runner() method of the CloudSqlDatabaseHook requires you to use the google_cloud_default_connection
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-4557
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4557
>             Project: Apache Airflow
>          Issue Type: Bug
>    Affects Versions: 1.10.3
>            Reporter: Andrew Harmon
>            Assignee: Andrew Harmon
>            Priority: Minor
>
> The get_sqlproxy_runner method of the CloudSqlDatabaseHook returns an instance of CloudSqlProxyRunner. This class allows you to specify a connection, but the method isn't passing in that parameter. Therefore the default value `google_cloud_default` always gets used for the CloudSqlProxyRunner. 
> the desired action should be that the CloudSqlProxyRunner uses the connection specified in the CloudSqlDatabaseHook



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)