You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/19 22:34:40 UTC

[GitHub] [airflow] drago-f5a commented on a change in pull request #13518: Fix webserver exiting when gunicorn master crashes

drago-f5a commented on a change in pull request #13518:
URL: https://github.com/apache/airflow/pull/13518#discussion_r560544581



##########
File path: airflow/cli/commands/webserver_command.py
##########
@@ -258,15 +258,15 @@ def _check_workers(self) -> None:
             num_workers_running = self._get_num_workers_running()
             if num_workers_running < self.num_workers_expected:
                 new_worker_count = min(
-                    num_workers_running - self.worker_refresh_batch_size, self.worker_refresh_batch_size
+                    self.num_workers_expected - num_workers_running, self.worker_refresh_batch_size
                 )
-                self.log.debug(
+                self.log.info(

Review comment:
       @kaxil 
   This action (spawning new workers) is taken specifically to correct an issue that was detected and logged at the error level few lines of code above. Given the prior error level log, it seemed reasonable to log an attempt at corrective action at the info level.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org