[GitHub] [geode] jinmeiliao opened pull request #2479: GEODE-3: more memory usage beans are available in java9. GemFireStatS…

["jinmeiliao (GitHub)" <gi...@apache.org>]

…amplerIntegrationTest needs to use production code to find the right Statistics to use.

* this fixes testLocalStatListenerRegistration test

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2479 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #2479: GEODE-3: more memory usage beans are available in java9. GemFireStatS…

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

I could be wrong but I thought "fine" mapped to "debug" not "trace". I think "trace" is for "finer" or "finest".
If I'm right then you should change all these new "trace" calls to "debug".

[ Full content available at: https://github.com/apache/geode/pull/2479 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on pull request #2479: GEODE-3: more memory usage beans are available in java9. GemFireStatS…

["jinmeiliao (GitHub)" <gi...@apache.org>]

there is no functional change in the production code. it's just the test is updated to use the production code to find the right Statistics to use

[ Full content available at: https://github.com/apache/geode/pull/2479 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on issue #2479: GEODE-3: more memory usage beans are available in java9. GemFireStatS…

["jinmeiliao (GitHub)" <gi...@apache.org>]

@galen-pivotal there is no functional change in the production code. it's just the test is updated to use the production code to find the right Statistics to use

[ Full content available at: https://github.com/apache/geode/pull/2479 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #2479: GEODE-3: more memory usage beans are available in java9. GemFireStatS…

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

HeapMemoryMonitor has a static "logger". Use that instead of "this.cache.getLogger()".

[ Full content available at: https://github.com/apache/geode/pull/2479 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao closed pull request #2479: GEODE-3: more memory usage beans are available in java9. GemFireStatS…

["jinmeiliao (GitHub)" <gi...@apache.org>]

[ pull request closed by jinmeiliao ]

[ Full content available at: https://github.com/apache/geode/pull/2479 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] galen-pivotal commented on pull request #2479: GEODE-3: more memory usage beans are available in java9. GemFireStatS…

["galen-pivotal (GitHub)" <gi...@apache.org>]

Perhaps `cache.getLoggerI18n()` could be replaced with the not-deprecated `cache.getLogger()`?

[ Full content available at: https://github.com/apache/geode/pull/2479 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org