You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by pa...@apache.org on 2020/11/22 05:24:50 UTC

[shardingsphere] branch master updated: Code format for ShardingCTLExplainBackendHandler & HintShowTableStatusExecutor (#8283)

This is an automated email from the ASF dual-hosted git repository.

panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 470a3ac  Code format for ShardingCTLExplainBackendHandler & HintShowTableStatusExecutor (#8283)
470a3ac is described below

commit 470a3ac3d90ca181e3f4f59351bb2a5070f0c652
Author: Liang Zhang <te...@163.com>
AuthorDate: Sun Nov 22 13:24:13 2020 +0800

    Code format for ShardingCTLExplainBackendHandler & HintShowTableStatusExecutor (#8283)
---
 .../text/sctl/explain/ShardingCTLExplainBackendHandler.java    |  9 +++++----
 .../hint/internal/executor/HintShowTableStatusExecutor.java    | 10 +++++-----
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/sctl/explain/ShardingCTLExplainBackendHandler.java b/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/sctl/explain/ShardingCTLExplainBackendHandler.java
index 7f9278c..833a591 100644
--- a/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/sctl/explain/ShardingCTLExplainBackendHandler.java
+++ b/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/sctl/explain/ShardingCTLExplainBackendHandler.java
@@ -41,6 +41,7 @@ import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.Iterator;
+import java.util.LinkedList;
 import java.util.List;
 import java.util.Optional;
 
@@ -94,9 +95,9 @@ public final class ShardingCTLExplainBackendHandler implements TextProtocolBacke
     @Override
     public Collection<Object> getRowData() {
         ExecutionUnit executionUnit = executionUnits.next();
-        Collection<Object> row = new ArrayList<>(queryHeaders.size());
-        row.add(executionUnit.getDataSourceName());
-        row.add(executionUnit.getSqlUnit().getSql());
-        return row;
+        Collection<Object> result = new LinkedList<>();
+        result.add(executionUnit.getDataSourceName());
+        result.add(executionUnit.getSqlUnit().getSql());
+        return result;
     }
 }
diff --git a/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/sctl/hint/internal/executor/HintShowTableStatusExecutor.java b/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/sctl/hint/internal/executor/HintShowTableStatusExecutor.java
index 0e16937..bd2cfb8 100644
--- a/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/sctl/hint/internal/executor/HintShowTableStatusExecutor.java
+++ b/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/sctl/hint/internal/executor/HintShowTableStatusExecutor.java
@@ -95,10 +95,10 @@ public final class HintShowTableStatusExecutor extends AbstractHintQueryExecutor
     }
     
     private List<Object> createRow(final HintShowTableStatusResult hintShowTableStatusResult) {
-        List<Object> row = new ArrayList<>(3);
-        row.add(hintShowTableStatusResult.getLogicTable());
-        row.add(Joiner.on(",").join(hintShowTableStatusResult.getDatabaseShardingValues()));
-        row.add(Joiner.on(",").join(hintShowTableStatusResult.getTableShardingValues()));
-        return row;
+        List<Object> result = new ArrayList<>(3);
+        result.add(hintShowTableStatusResult.getLogicTable());
+        result.add(Joiner.on(",").join(hintShowTableStatusResult.getDatabaseShardingValues()));
+        result.add(Joiner.on(",").join(hintShowTableStatusResult.getTableShardingValues()));
+        return result;
     }
 }