You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by "VinayakMarraiya230920 (via GitHub)" <gi...@apache.org> on 2026/08/19 06:08:16 UTC
[PR] ATLAS-5379 : Authorize lineage neighbor entities before returning headers [atlas]
VinayakMarraiya230920 opened a new pull request, #731:
URL: https://github.com/apache/atlas/pull/731
Apply per-entity ENTITY_READ checks when building lineage guidEntityMap. Skip unauthorized neighbors and omit relations when either endpoint is not readable.
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix. Create an issue in ASF JIRA before opening a pull request and
set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. ATLAS-XXXX: Fix a typo in YYY))
## How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5379 : Authorize lineage neighbor entities before returning headers [atlas]
Posted by "mneethiraj (via GitHub)" <gi...@apache.org>.
mneethiraj commented on code in PR #731:
URL: https://github.com/apache/atlas/pull/731#discussion_r3909470494
##########
repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java:
##########
@@ -654,31 +654,40 @@ private void processEdge(final AtlasEdge edge, final Map<String, AtlasEntityHead
String relationGuid = AtlasGraphUtilsV2.getEncodedProperty(edge, RELATIONSHIP_GUID_PROPERTY_KEY, String.class);
boolean isInputEdge = edge.getLabel().equalsIgnoreCase(PROCESS_INPUTS_EDGE);
- if (!entities.containsKey(inGuid)) {
- AtlasEntityHeader entityHeader = entityRetriever.toAtlasEntityHeader(inVertex);
+ addEntityHeaderIfAuthorized(inVertex, inGuid, entities);
Review Comment:
Instead of `skipping` entities as encountered while retrieving the lineage, I suggest gathering entire lineage details in `AtlasLineageInfo` and `scrubbing` it - similar to search result scrubbing in `EntityDiscoveryService.scrubSearchResults()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5379 : Authorize lineage neighbor entities before returning headers [atlas]
Posted by "VinayakMarraiya230920 (via GitHub)" <gi...@apache.org>.
VinayakMarraiya230920 commented on code in PR #731:
URL: https://github.com/apache/atlas/pull/731#discussion_r3965009336
##########
repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java:
##########
@@ -654,31 +654,40 @@ private void processEdge(final AtlasEdge edge, final Map<String, AtlasEntityHead
String relationGuid = AtlasGraphUtilsV2.getEncodedProperty(edge, RELATIONSHIP_GUID_PROPERTY_KEY, String.class);
boolean isInputEdge = edge.getLabel().equalsIgnoreCase(PROCESS_INPUTS_EDGE);
- if (!entities.containsKey(inGuid)) {
- AtlasEntityHeader entityHeader = entityRetriever.toAtlasEntityHeader(inVertex);
+ addEntityHeaderIfAuthorized(inVertex, inGuid, entities);
Review Comment:
Thanks @mneethiraj — done, now scrubs instead of omitting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5379 : Authorize lineage neighbor entities before returning headers [atlas]
Posted by "nixonrodrigues (via GitHub)" <gi...@apache.org>.
nixonrodrigues merged PR #731:
URL: https://github.com/apache/atlas/pull/731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org