You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/07/13 16:21:40 UTC
[GitHub] [couchdb] noahshaw11 opened a new pull request, #4104: Remove view compaction jobs recovery
noahshaw11 opened a new pull request, #4104:
URL: https://github.com/apache/couchdb/pull/4104
## Overview
Persistence and recovery of view compaction jobs was never intended. This PR adds a check to skip the process for view compaction jobs.
## Testing recommendations
```
make eunit apps=smoosh
```
## Related Issues or Pull Requests
Add smoosh queue persistence: https://github.com/apache/couchdb/pull/3766
## Checklist
- [ ] Code is written and works correctly
- [ ] Changes are covered by tests
- [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] noahshaw11 commented on a diff in pull request #4104: Remove view compaction jobs recovery
Posted by GitBox <gi...@apache.org>.
noahshaw11 commented on code in PR #4104:
URL: https://github.com/apache/couchdb/pull/4104#discussion_r920320795
##########
src/smoosh/src/smoosh_channel.erl:
##########
@@ -28,6 +28,11 @@
terminate/2
]).
+-define(VIEW_CHANNELS,
+ smoosh_utils:split(
+ config:get("smoosh", "view_channels", "upgrade_views,ratio_views,slack_views")
+ )
+).
Review Comment:
Ah, I like that idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on a diff in pull request #4104: Remove view compaction jobs recovery
Posted by GitBox <gi...@apache.org>.
nickva commented on code in PR #4104:
URL: https://github.com/apache/couchdb/pull/4104#discussion_r920320315
##########
src/smoosh/src/smoosh_channel.erl:
##########
@@ -28,6 +28,11 @@
terminate/2
]).
+-define(VIEW_CHANNELS,
+ smoosh_utils:split(
+ config:get("smoosh", "view_channels", "upgrade_views,ratio_views,slack_views")
+ )
+).
Review Comment:
Instead of a macro, I think it might look nicer as `smoosh_utils:is_view_channel(ChanName)` call. So we can keep the splitting and config in that module only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva closed pull request #4104: Remove view compaction jobs recovery and improve is_compacting/1 test
Posted by GitBox <gi...@apache.org>.
nickva closed pull request #4104: Remove view compaction jobs recovery and improve is_compacting/1 test
URL: https://github.com/apache/couchdb/pull/4104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org