You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2021/09/23 00:23:58 UTC
[Impala-ASF-CR] IMPALA-10928: Upgrade source of Kudu's EasyCurl in kudu/util
Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17864
Change subject: IMPALA-10928: Upgrade source of Kudu's EasyCurl in kudu/util
......................................................................
IMPALA-10928: Upgrade source of Kudu's EasyCurl in kudu/util
We are going to use Kudu's EasyCurl wrapper to download file in Impala.
There are some enhancements for Kudu's EasyCurl in Kudu upstream since
the last sync of kudu/util with Kudu repo. This patch upgraded source
code for Kudu's EasyCurl wrapper (curl_util.cc and curl_util.h in
kudu/util) from the top of Kudu upstream (commit hash: 41ebabf2eb).
Note that curl_util.cc/curl_util.h have dependency on libcurl, which
is not integrated in Impala. curl_util.cc is not built with current
kudu/util/CMakeLists.txt. We will integrate curl_util.cc/curl_util.h
when we integrate libcurl in following patch.
Testing:
- There is no impact for Impala tests.
Change-Id: I51fea9ff4de767bfda2a4ebcd3744d63440adf14
---
M be/src/kudu/util/curl_util-test.cc
M be/src/kudu/util/curl_util.cc
M be/src/kudu/util/curl_util.h
3 files changed, 155 insertions(+), 52 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/17864/1
--
To view, visit http://gerrit.cloudera.org:8080/17864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I51fea9ff4de767bfda2a4ebcd3744d63440adf14
Gerrit-Change-Number: 17864
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10928: Upgrade source of Kudu's EasyCurl in kudu/util
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17864 )
Change subject: IMPALA-10928: Upgrade source of Kudu's EasyCurl in kudu/util
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7486/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51fea9ff4de767bfda2a4ebcd3744d63440adf14
Gerrit-Change-Number: 17864
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Sep 2021 18:18:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10928: Upgrade source of Kudu's EasyCurl in kudu/util
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17864 )
Change subject: IMPALA-10928: Upgrade source of Kudu's EasyCurl in kudu/util
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9491/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51fea9ff4de767bfda2a4ebcd3744d63440adf14
Gerrit-Change-Number: 17864
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Sep 2021 00:45:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10928: Upgrade source of Kudu's EasyCurl in kudu/util
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17864 )
Change subject: IMPALA-10928: Upgrade source of Kudu's EasyCurl in kudu/util
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51fea9ff4de767bfda2a4ebcd3744d63440adf14
Gerrit-Change-Number: 17864
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Sep 2021 00:38:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10928: Upgrade source of Kudu's EasyCurl in kudu/util
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17864 )
Change subject: IMPALA-10928: Upgrade source of Kudu's EasyCurl in kudu/util
......................................................................
Patch Set 2: Code-Review+2
This makes sense to me.
--
To view, visit http://gerrit.cloudera.org:8080/17864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51fea9ff4de767bfda2a4ebcd3744d63440adf14
Gerrit-Change-Number: 17864
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Sep 2021 17:35:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10928: Upgrade source of Kudu's EasyCurl in kudu/util
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17864 )
Change subject: IMPALA-10928: Upgrade source of Kudu's EasyCurl in kudu/util
......................................................................
IMPALA-10928: Upgrade source of Kudu's EasyCurl in kudu/util
We are going to use Kudu's EasyCurl wrapper to download file in Impala.
There are some enhancements for Kudu's EasyCurl in Kudu upstream since
the last sync of kudu/util with Kudu repo. This patch upgraded source
code for Kudu's EasyCurl wrapper (curl_util.cc and curl_util.h in
kudu/util) from the Kudu upstream (commit hash: 37bc427a60, b417479266,
a33b0951d9, 9050941663, e371d80f3e).
Note that curl_util.cc/curl_util.h have dependency on libcurl, which
is not integrated in Impala. curl_util.cc is not built with current
kudu/util/CMakeLists.txt. We will integrate curl_util.cc/curl_util.h
when we integrate libcurl in following patch.
Testing:
- There is no impact for Impala tests.
Change-Id: I51fea9ff4de767bfda2a4ebcd3744d63440adf14
---
M be/src/kudu/util/curl_util-test.cc
M be/src/kudu/util/curl_util.cc
M be/src/kudu/util/curl_util.h
3 files changed, 155 insertions(+), 52 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/17864/2
--
To view, visit http://gerrit.cloudera.org:8080/17864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I51fea9ff4de767bfda2a4ebcd3744d63440adf14
Gerrit-Change-Number: 17864
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10928: Upgrade source of Kudu's EasyCurl in kudu/util
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17864 )
Change subject: IMPALA-10928: Upgrade source of Kudu's EasyCurl in kudu/util
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9492/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51fea9ff4de767bfda2a4ebcd3744d63440adf14
Gerrit-Change-Number: 17864
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Sep 2021 04:41:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10928: Upgrade source of Kudu's EasyCurl in kudu/util
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17864 )
Change subject: IMPALA-10928: Upgrade source of Kudu's EasyCurl in kudu/util
......................................................................
IMPALA-10928: Upgrade source of Kudu's EasyCurl in kudu/util
We are going to use Kudu's EasyCurl wrapper to download file in Impala.
There are some enhancements for Kudu's EasyCurl in Kudu upstream since
the last sync of kudu/util with Kudu repo. This patch upgraded source
code for Kudu's EasyCurl wrapper (curl_util.cc and curl_util.h in
kudu/util) from the Kudu upstream (commit hash: 37bc427a60, b417479266,
a33b0951d9, 9050941663, e371d80f3e).
Note that curl_util.cc/curl_util.h have dependency on libcurl, which
is not integrated in Impala. curl_util.cc is not built with current
kudu/util/CMakeLists.txt. We will integrate curl_util.cc/curl_util.h
when we integrate libcurl in following patch.
Testing:
- There is no impact for Impala tests.
Change-Id: I51fea9ff4de767bfda2a4ebcd3744d63440adf14
Reviewed-on: http://gerrit.cloudera.org:8080/17864
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/kudu/util/curl_util-test.cc
M be/src/kudu/util/curl_util.cc
M be/src/kudu/util/curl_util.h
3 files changed, 155 insertions(+), 52 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I51fea9ff4de767bfda2a4ebcd3744d63440adf14
Gerrit-Change-Number: 17864
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>