You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bifromq.apache.org by GitBox <gi...@apache.org> on 2026/10/25 18:01:58 UTC
[GH] (bifromq/fix/kv-client-pipeline-leak): Workflow run "Build and Test BifroMQ" failed!
The GitHub Actions job "Build and Test BifroMQ" on bifromq.git/fix/kv-client-pipeline-leak has failed.
Run started by GitHub user ImDanXie (triggered by ImDanXie).
Head commit for run:
172d0a6daff853d21cb09a7e41771b86252e0e18 / ImDanXie <wo...@gmail.com>
fix(kv-client): close mutation pipelines dropped by a route refresh
refreshMutPipelines() rebuilds the per-store/per-range mutation pipeline map
and assigns it, but only closed pipelines of stores that vanished entirely.
A pipeline whose range is no longer led by that store (the regular outcome of
a RangeLeaderBalancer leadership transfer or a merge) was simply dropped:
its RX subscription, its dedicated gRPC bidi stream and the server-side
MutatePipeline leaked on every topology event - unreachable from close() -
giving monotonically growing resource usage on long-running brokers.
Replace the store-level-only clear loop with a general pass that closes every
pipeline instance absent from (or replaced in) the new map, extracted as a
package-private static helper for direct unit testing.
Tests: range-leadership-move / store-disappear / instance-replaced cases
(new BaseKVStoreClientPipelineRefreshTest).
Fixes #302
Report URL: https://github.com/apache/bifromq/actions/runs/36170692554
With regards,
GitHub Actions via GitBox