You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/19 10:27:21 UTC
[GitHub] [superset] kgabryje commented on a diff in pull request #20126: feat(dashboard): Add create chart button in dashboard edit mode
kgabryje commented on code in PR #20126:
URL: https://github.com/apache/superset/pull/20126#discussion_r876888269
##########
superset-frontend/src/dashboard/components/SliceAdder.jsx:
##########
@@ -240,6 +271,18 @@ class SliceAdder extends React.Component {
MARGIN_BOTTOM;
return (
<div className="slice-adder-container">
+ <NewChartButtonContainer>
+ <NewChartButton
+ buttonStyle="link"
+ buttonSize="xsmall"
+ onClick={() =>
+ window.open('/chart/add', '_blank', 'noopener noreferrer')
Review Comment:
Good idea! But wouldn't we actually need to use websocket instead to update the list when chart is saved on the backend? I just wonder if such frontend communication would be reliable enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org