You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/04/22 06:17:06 UTC

[GitHub] [incubator-doris] acelyc111 opened a new issue #3375: Bloom filter bits buffer is not initialized as 0

acelyc111 opened a new issue #3375:
URL: https://github.com/apache/incubator-doris/issues/3375


   **Describe the bug**
   I found this bug when I run unit tests in [ASAN](http://doris.incubator.apache.org/documentation/cn/developer-guide/debug-tool.html#asan) mode,
   `TEST_F(BlockBloomFilterTest, SP)` in be/test/olap/rowset/segment_v2/block_bloom_filter_test.cpp failed definitely.
   ```
   $ ${DORIS_TEST_BINARY_DIR}/olap/rowset/segment_v2/block_bloom_filter_test
   [==========] Running 3 tests from 1 test case.
   [----------] Global test environment set-up.
   [----------] 3 tests from BlockBloomFilterTest
   [ RUN      ] BlockBloomFilterTest.Normal
   [       OK ] BlockBloomFilterTest.Normal (1 ms)
   [ RUN      ] BlockBloomFilterTest.SP
   /home/laiyingchun/ap_doris/be/test/olap/rowset/segment_v2/block_bloom_filter_test.cpp:142: Failure
   Expected: ((double)false_count2 / (num * 9)) <= (_fpp), actual: 0.312934 vs 0.05
   [  FAILED  ] BlockBloomFilterTest.SP (7 ms)
   [ RUN      ] BlockBloomFilterTest.slice
   [       OK ] BlockBloomFilterTest.slice (1 ms)
   [----------] 3 tests from BlockBloomFilterTest (9 ms total)
   
   [----------] Global test environment tear-down
   [==========] 3 tests from 1 test case ran. (9 ms total)
   [  PASSED  ] 2 tests.
   [  FAILED  ] 1 test, listed below:
   [  FAILED  ] BlockBloomFilterTest.SP
   ```
   
   **To Reproduce**
   Steps to reproduce the behavior:
   1. Run unit test `${DORIS_TEST_BINARY_DIR}/olap/rowset/segment_v2/block_bloom_filter_test` in ASAN mode for the old unit test code, or in default (release) mode for the improved unit test code in https://github.com/apache/incubator-doris/pull/3372.
   
   **Expected behavior**
   All unit tests should passed.
   That is to say **false positive proportion** of bloom filter should be in a very low proportion as what we specify the parameter when we initilize BloomFilter, for example 0.05.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org