You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by liyinan926 <gi...@git.apache.org> on 2018/01/04 23:10:50 UTC
[GitHub] spark pull request #20160: Enable spark.jars and spark.files in KUBERNETES m...
GitHub user liyinan926 opened a pull request:
https://github.com/apache/spark/pull/20160
Enable spark.jars and spark.files in KUBERNETES mode
## What changes were proposed in this pull request?
We missed enabling `spark.files` and `spark.jars` in https://github.com/apache/spark/pull/19954. The result is that remote dependencies specified through `spark.files` or `spark.jars` are not included in the list of remote dependencies to be downloaded by the init-container. This PR fixes it.
## How was this patch tested?
Manual tests.
@vanzin This replaces https://github.com/apache/spark/pull/20157.
@foxish
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liyinan926/spark-k8s SPARK-22757
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20160.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20160
----
commit 1075cfc9ce18f3717bbbeb9950eafdda219f7233
Author: Yinan Li <li...@...>
Date: 2018-01-04T21:29:04Z
Enable spark.jars and spark.files in KUBERNETES mode
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20160: [SPARK-22757][K8S] Enable spark.jars and spark.files in ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20160
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85703/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20160: [SPARK-22757][K8S] Enable spark.jars and spark.fi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20160
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20160: [SPARK-22757][K8S] Enable spark.jars and spark.files in ...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20160
test passed, merged to master/2.3.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20160: [SPARK-22757][K8S] Enable spark.jars and spark.files in ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20160
**[Test build #85703 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85703/testReport)** for PR 20160 at commit [`1075cfc`](https://github.com/apache/spark/commit/1075cfc9ce18f3717bbbeb9950eafdda219f7233).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20160: Enable spark.jars and spark.files in KUBERNETES mode
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20160
**[Test build #85703 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85703/testReport)** for PR 20160 at commit [`1075cfc`](https://github.com/apache/spark/commit/1075cfc9ce18f3717bbbeb9950eafdda219f7233).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20160: [SPARK-22757][K8S] Enable spark.jars and spark.files in ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20160
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org