[GitHub] [iceberg] zhengxingmao commented on a change in pull request #3808: ORC: Add ORC bloom filter attributes to iceberg table

[GitBox <gi...@apache.org>]

zhengxingmao commented on a change in pull request #3808:
URL: https://github.com/apache/iceberg/pull/3808#discussion_r790376378



##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -129,6 +129,8 @@ private TableProperties() {
   public static final String PARQUET_BATCH_SIZE = "read.parquet.vectorization.batch-size";
   public static final int PARQUET_BATCH_SIZE_DEFAULT = 5000;
 
+  public static final String ORC_BLOOM_FILTER_COLUMNS = "orc.bloom.filter.columns";
+  public static final String ORC_BLOOM_FILTER_FPP = "orc.bloom.filter.fpp";

Review comment:
       These two parameters are used for Trino, not iceberg. The relevant implementation code is in Trino.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org