[GitHub] [superset] villebro commented on a diff in pull request #21154: [WIP] fix(explore): Prevent unnecessary series limit subquery

[GitBox <gi...@apache.org>]

villebro commented on code in PR #21154:
URL: https://github.com/apache/superset/pull/21154#discussion_r953397704


##########
superset/connectors/sqla/models.py:
##########
@@ -1410,7 +1410,7 @@ def get_sqla_query(  # pylint: disable=too-many-arguments,too-many-locals,too-ma
                         col=selected, template_processor=template_processor
                     )
                 groupby_all_columns[outer.name] = outer
-                if not series_column_names or outer.name in series_column_names:
+                if outer.name in series_column_names:

Review Comment:
   I think this should work - legacy timeseries charts will have set `is_timeseries` to `True`, and new charts will no longer be using it:
   ```suggestion
                   if (
                       is_timeseries and not series_column_names
                   ) or outer.name in series_column_names:
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org