[jira] [Commented] (THRIFT-2689) struct names that differ only in capitalization of first character generate broken erlang code

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155328#comment-14155328 ] 

ASF GitHub Bot commented on THRIFT-2689:
----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/204


> struct names that differ only in capitalization of first character generate broken erlang code
> ----------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-2689
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2689
>             Project: Thrift
>          Issue Type: Bug
>          Components: Erlang - Compiler, Erlang - Library
>            Reporter: alisdair sullivan
>            Assignee: alisdair sullivan
>            Priority: Minor
>             Fix For: 0.9.2
>
>
> the following thrift specification generates broken erlang code:
> struct invalid { /* contents of struct are irrelevent */ }
> struct Invalid { /* still irrelevent }
> the compiler currently renames any struct that starts with a capital so that it starts with a lowercase letter. instead, it should leave names intact and use proper erlang syntax in generation. the attached patch does exactly that
> this does break backwards compatibility



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)