[GitHub] [flink-connector-hbase] zentol commented on a diff in pull request #4: [FLINK-30062][Connectors/HBase] ADDENDUM: Bundle the exact same dependencies as it was in core

[GitBox <gi...@apache.org>]

zentol commented on code in PR #4:
URL: https://github.com/apache/flink-connector-hbase/pull/4#discussion_r1045591536


##########
flink-sql-connector-hbase-2.2/pom.xml:
##########
@@ -39,15 +39,25 @@ under the License.
 			<groupId>org.apache.flink</groupId>
 			<artifactId>flink-connector-hbase-2.2</artifactId>
 			<version>${project.version}</version>
-			<exclusions>
-				<exclusion>
-					<groupId>org.apache.hbase</groupId>
-					<artifactId>hbase-client</artifactId>
-				</exclusion>
-			</exclusions>
 		</dependency>
 	</dependencies>
 
+	<dependencyManagement>
+		<dependencies>
+			<dependency>
+				<groupId>commons-io</groupId>
+				<artifactId>commons-io</artifactId>
+				<version>2.11.0</version>
+			</dependency>
+
+			<dependency>
+				<groupId>org.apache.commons</groupId>
+				<artifactId>commons-lang3</artifactId>
+				<version>3.12.0</version>

Review Comment:
   This is a different version than what we had in 1.16.0 (3.3.2)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org