You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2019/01/25 01:16:55 UTC
[Impala-ASF-CR] IMPALA-8114: Deflake test breakpad.py
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12273
Change subject: IMPALA-8114: Deflake test_breakpad.py
......................................................................
IMPALA-8114: Deflake test_breakpad.py
A test failed recently in a private build and it looked like the loop in
wait_for_num_processes had terminated to early. To make sure that the
forked of processes that write the minidumps have actually started, we
now sleep for 1 second before entering the wait loop.
Change-Id: Ifcd1fbb498c475a1f186f490abaf90b47ecba05b
---
M tests/custom_cluster/test_breakpad.py
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/12273/1
--
To view, visit http://gerrit.cloudera.org:8080/12273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifcd1fbb498c475a1f186f490abaf90b47ecba05b
Gerrit-Change-Number: 12273
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-8114: Deflake test breakpad.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12273 )
Change subject: IMPALA-8114: Deflake test_breakpad.py
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1883/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd1fbb498c475a1f186f490abaf90b47ecba05b
Gerrit-Change-Number: 12273
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Jan 2019 01:40:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8114: Deflake test breakpad.py
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12273 )
Change subject: IMPALA-8114: Deflake test_breakpad.py
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd1fbb498c475a1f186f490abaf90b47ecba05b
Gerrit-Change-Number: 12273
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Jan 2019 19:54:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8114: Deflake test breakpad.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12273 )
Change subject: IMPALA-8114: Deflake test_breakpad.py
......................................................................
IMPALA-8114: Deflake test_breakpad.py
A test failed recently in a private build and it looked like the loop in
wait_for_num_processes had terminated to early. To make sure that the
forked of processes that write the minidumps have actually started, we
now sleep for 1 second before entering the wait loop.
Change-Id: Ifcd1fbb498c475a1f186f490abaf90b47ecba05b
Reviewed-on: http://gerrit.cloudera.org:8080/12273
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_breakpad.py
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifcd1fbb498c475a1f186f490abaf90b47ecba05b
Gerrit-Change-Number: 12273
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8114: Deflake test breakpad.py
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12273 )
Change subject: IMPALA-8114: Deflake test_breakpad.py
......................................................................
Patch Set 1: Code-Review+2
We could probably do something a little more clever like waiting until we see > 3 processes, but I don't know if that is ultimately any better than this.
--
To view, visit http://gerrit.cloudera.org:8080/12273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd1fbb498c475a1f186f490abaf90b47ecba05b
Gerrit-Change-Number: 12273
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Jan 2019 01:24:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8114: Deflake test breakpad.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12273 )
Change subject: IMPALA-8114: Deflake test_breakpad.py
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd1fbb498c475a1f186f490abaf90b47ecba05b
Gerrit-Change-Number: 12273
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Jan 2019 23:41:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8114: Deflake test breakpad.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12273 )
Change subject: IMPALA-8114: Deflake test_breakpad.py
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3676/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd1fbb498c475a1f186f490abaf90b47ecba05b
Gerrit-Change-Number: 12273
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Jan 2019 19:42:53 +0000
Gerrit-HasComments: No