You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/05/01 00:23:47 UTC
[kudu-CR] RetryRule: don't report NTP desynchronization test failures
Hello Will Berkeley, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13206
to review the following change.
Change subject: RetryRule: don't report NTP desynchronization test failures
......................................................................
RetryRule: don't report NTP desynchronization test failures
This mirrors the logic in build-support/report-test.sh which skips reporting
of a failed test if there was an NTP clock synchronization issue.
I went back and forth on whether to do this in RetryRule or ResultReporter,
but settled on RetryRule as it seemed like the better place for "policy". I
also figured spawning a subprocess is faster (and easier) than doing a
primitive grep via Java APIs.
I tested this by running a local test result server and injecting a failure
into a test, once with the magic desynchronization string, and once without.
I saw the failure get reported in the former and skipped in the latter.
Change-Id: Ibba9768775f225425e98c3c36733aefcc7a42a11
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java
1 file changed, 21 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/13206/1
--
To view, visit http://gerrit.cloudera.org:8080/13206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibba9768775f225425e98c3c36733aefcc7a42a11
Gerrit-Change-Number: 13206
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] RetryRule: don't report NTP desynchronization test failures
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13206 )
Change subject: RetryRule: don't report NTP desynchronization test failures
......................................................................
RetryRule: don't report NTP desynchronization test failures
This mirrors the logic in build-support/report-test.sh which skips reporting
of a failed test if there was an NTP clock synchronization issue.
I went back and forth on whether to do this in RetryRule or ResultReporter,
but settled on RetryRule as it seemed like the better place for "policy". I
also figured spawning a subprocess is faster (and easier) than doing a
primitive grep via Java APIs.
I tested this by running a local test result server and injecting a failure
into a test, once with the magic desynchronization string, and once without.
I saw the failure get reported in the former and skipped in the latter.
Change-Id: Ibba9768775f225425e98c3c36733aefcc7a42a11
Reviewed-on: http://gerrit.cloudera.org:8080/13206
Tested-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java
1 file changed, 21 insertions(+), 1 deletion(-)
Approvals:
Adar Dembo: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibba9768775f225425e98c3c36733aefcc7a42a11
Gerrit-Change-Number: 13206
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] RetryRule: don't report NTP desynchronization test failures
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13206 )
Change subject: RetryRule: don't report NTP desynchronization test failures
......................................................................
Patch Set 1: Verified+1
Overriding Jenkins, a dist-test slave had NTP synchronization issues.
--
To view, visit http://gerrit.cloudera.org:8080/13206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibba9768775f225425e98c3c36733aefcc7a42a11
Gerrit-Change-Number: 13206
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 01 May 2019 04:02:12 +0000
Gerrit-HasComments: No
[kudu-CR] RetryRule: don't report NTP desynchronization test failures
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13206 )
Change subject: RetryRule: don't report NTP desynchronization test failures
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ibba9768775f225425e98c3c36733aefcc7a42a11
Gerrit-Change-Number: 13206
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] RetryRule: don't report NTP desynchronization test failures
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13206 )
Change subject: RetryRule: don't report NTP desynchronization test failures
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibba9768775f225425e98c3c36733aefcc7a42a11
Gerrit-Change-Number: 13206
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 01 May 2019 13:02:54 +0000
Gerrit-HasComments: No