You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/03/25 17:11:15 UTC

[GitHub] [hadoop-ozone] cku328 opened a new pull request #722: HDDS-3074. Make the configuration of container scrub consistent.

cku328 opened a new pull request #722: HDDS-3074. Make the configuration of container scrub consistent.
URL: https://github.com/apache/hadoop-ozone/pull/722
 
 
   ## What changes were proposed in this pull request?
   
   When we set `hdds.container.scrub.enabled` (in ozone-site.xml) to true, container scrub didn't work because the [prefix of the configuration](https://github.com/apache/hadoop-ozone/blob/f6be7660a52ac0e7ebfa3818989c30c0b9f977ed/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/ContainerScrubberConfiguration.java#L28) is incorrect, like this:
   
   ![ds1](https://user-images.githubusercontent.com/14295594/77563517-5845ba00-6efc-11ea-8895-f57b8a994402.png)
   
   So I fixed the prefix of the configuration (replace it with **hdds.container.scrub**), it did work.
   
   ![ds2](https://user-images.githubusercontent.com/14295594/77563533-5e3b9b00-6efc-11ea-9df2-f1d1a6ed3c0b.png)
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/projects/HDDS/issues/HDDS-3074
   
   ## How was this patch tested?
   
   Check logs on Ozone Single Cluster.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #722: HDDS-3074. Make the configuration of container scrub consistent.

Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on issue #722: HDDS-3074. Make the configuration of container scrub consistent.
URL: https://github.com/apache/hadoop-ozone/pull/722#issuecomment-604819927
 
 
   Test failures are unrelated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #722: HDDS-3074. Make the configuration of container scrub consistent.

Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on issue #722: HDDS-3074. Make the configuration of container scrub consistent.
URL: https://github.com/apache/hadoop-ozone/pull/722#issuecomment-604820134
 
 
   Thank You @cku328 for the contribution.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] cku328 commented on issue #722: HDDS-3074. Make the configuration of container scrub consistent.

Posted by GitBox <gi...@apache.org>.
cku328 commented on issue #722: HDDS-3074. Make the configuration of container scrub consistent.
URL: https://github.com/apache/hadoop-ozone/pull/722#issuecomment-606544142
 
 
   Thanks @avijayanhwx & @bharatviswa504 for the review, and @elek for your advice on flaky test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] avijayanhwx commented on issue #722: HDDS-3074. Make the configuration of container scrub consistent.

Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on issue #722: HDDS-3074. Make the configuration of container scrub consistent.
URL: https://github.com/apache/hadoop-ozone/pull/722#issuecomment-603974479
 
 
   LGTM +1 pending CI.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] elek commented on issue #722: HDDS-3074. Make the configuration of container scrub consistent.

Posted by GitBox <gi...@apache.org>.
elek commented on issue #722: HDDS-3074. Make the configuration of container scrub consistent.
URL: https://github.com/apache/hadoop-ozone/pull/722#issuecomment-604986683
 
 
   If you see a flaky test, please disable it (without and issue) + create a new open issue and repeat the build. There is some risk that one flakiness hides a other. Merging patches without green build makes harder to debug flaky tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] bharatviswa504 merged pull request #722: HDDS-3074. Make the configuration of container scrub consistent.

Posted by GitBox <gi...@apache.org>.
bharatviswa504 merged pull request #722: HDDS-3074. Make the configuration of container scrub consistent.
URL: https://github.com/apache/hadoop-ozone/pull/722
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org