[GitHub] [incubator-devlake] aFlyBird0 commented on pull request #4607: ci: sync image tags to helm chart

["aFlyBird0 (via GitHub)" <gi...@apache.org>]

aFlyBird0 commented on PR #4607:
URL: https://github.com/apache/incubator-devlake/pull/4607#issuecomment-1459533037

   > Great Job.
   > 
   > Two more comments:
   > 
   > 1. Suggest adding this stage as the last stage in build.yml, as we need to ensure the images are pushed success, then trigger the helm chart promote version.
   > 2. Previously, only actions from verified creators are allowed in this repo.
   
   Thank you for you careful review! @matrixji 
   
   For the second suggestion, I want to use the way above to sovle it:
   
    Using`git submodule` to download actions to `.workflows/actions` in `apache/incubator-devalke`, like the solutions in helm chart: 
   
   https://github.com/apache/incubator-devlake-helm-chart/tree/main/.github/actions
   
   <img width="370" alt="image" src="https://user-images.githubusercontent.com/36830265/223626378-69caea4e-7e07-4b33-a04d-4e18966141ad.png">
   
   Is it allowed?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org