[GitHub] rahul003 commented on a change in pull request #11027: Add standard ResNet data augmentation for ImageRecordIter

[GitBox <gi...@apache.org>]

rahul003 commented on a change in pull request #11027: Add standard ResNet data augmentation for ImageRecordIter
URL: https://github.com/apache/incubator-mxnet/pull/11027#discussion_r194184683
 
 

 ##########
 File path: example/image-classification/common/data.py
 ##########
 @@ -63,6 +65,20 @@ def add_data_aug_args(parser):
                      help='max ratio to scale')
     aug.add_argument('--min-random-scale', type=float, default=1,
                      help='min ratio to scale, should >= img_size/input_shape. otherwise use --pad-size')
+    aug.add_argument('--max-random-area', type=float, default=1,
+                     help='max area to crop in random resized crop, whose range is [0, 1]')
+    aug.add_argument('--min-random-area', type=float, default=1,
+                     help='min area to crop in random resized crop, whose range is [0, 1]')
+    aug.add_argument('--brightness', type=float, default=0,
 
 Review comment:
   I think it would be better to set defaults to the values we know work well

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services