You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/10/15 02:24:28 UTC

Review Request 26715: Supported O_CLOEXEC for os::open on all platforms.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26715/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Vinod Kone.


Repository: mesos-git


Description
-------

This patch allows us to use O_CLOEXEC even if it's not available on some distributions.

Will follow up with a patch to cleanup the code.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp ec41fe412290a152a15a49e091f0bc6436e42cfd 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 898d175980e397493270454aafdf340a96c9cf85 

Diff: https://reviews.apache.org/r/26715/diff/


Testing
-------

make check

both on mac and linux


Thanks,

Jie Yu


Re: Review Request 26715: Supported O_CLOEXEC for os::open on all platforms.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26715/#review56642
-----------------------------------------------------------


Patch looks great!

Reviews applied: [26715]

All tests passed.

- Mesos ReviewBot


On Oct. 15, 2014, 12:24 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26715/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 12:24 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This patch allows us to use O_CLOEXEC even if it's not available on some distributions.
> 
> Will follow up with a patch to cleanup the code.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp ec41fe412290a152a15a49e091f0bc6436e42cfd 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 898d175980e397493270454aafdf340a96c9cf85 
> 
> Diff: https://reviews.apache.org/r/26715/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> both on mac and linux
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 26715: Supported O_CLOEXEC for os::open on all platforms.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26715/#review56880
-----------------------------------------------------------


Patch looks great!

Reviews applied: [26715]

All tests passed.

- Mesos ReviewBot


On Oct. 16, 2014, 1:09 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26715/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 1:09 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This patch allows us to use O_CLOEXEC even if it's not available on some distributions.
> 
> Will follow up with a patch to cleanup the code.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp ec41fe412290a152a15a49e091f0bc6436e42cfd 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 898d175980e397493270454aafdf340a96c9cf85 
> 
> Diff: https://reviews.apache.org/r/26715/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> both on mac and linux
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 26715: Supported O_CLOEXEC for os::open on all platforms.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26715/#review56959
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Oct. 16, 2014, 1:09 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26715/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 1:09 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This patch allows us to use O_CLOEXEC even if it's not available on some distributions.
> 
> Will follow up with a patch to cleanup the code.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp ec41fe412290a152a15a49e091f0bc6436e42cfd 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 898d175980e397493270454aafdf340a96c9cf85 
> 
> Diff: https://reviews.apache.org/r/26715/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> both on mac and linux
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 26715: Supported O_CLOEXEC for os::open on all platforms.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26715/
-----------------------------------------------------------

(Updated Oct. 16, 2014, 1:09 a.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
-------

Review comments.


Repository: mesos-git


Description
-------

This patch allows us to use O_CLOEXEC even if it's not available on some distributions.

Will follow up with a patch to cleanup the code.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp ec41fe412290a152a15a49e091f0bc6436e42cfd 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 898d175980e397493270454aafdf340a96c9cf85 

Diff: https://reviews.apache.org/r/26715/diff/


Testing
-------

make check

both on mac and linux


Thanks,

Jie Yu


Re: Review Request 26715: Supported O_CLOEXEC for os::open on all platforms.

Posted by Jie Yu <yu...@gmail.com>.

> On Oct. 15, 2014, 5:55 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 288
> > <https://reviews.apache.org/r/26715/diff/1/?file=721176#file721176line288>
> >
> >     shouldn't this be a hex value?
> >     
> >     also, why are the hex values different for linux and apple?

Because linux kernel is different from bsd kernel:)

I copied the value from the system header files. I'll include comments about where I copied from.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26715/#review56741
-----------------------------------------------------------


On Oct. 15, 2014, 12:24 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26715/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 12:24 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This patch allows us to use O_CLOEXEC even if it's not available on some distributions.
> 
> Will follow up with a patch to cleanup the code.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp ec41fe412290a152a15a49e091f0bc6436e42cfd 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 898d175980e397493270454aafdf340a96c9cf85 
> 
> Diff: https://reviews.apache.org/r/26715/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> both on mac and linux
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 26715: Supported O_CLOEXEC for os::open on all platforms.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26715/#review56741
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
<https://reviews.apache.org/r/26715/#comment97121>

    s/simply/simplify/



3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
<https://reviews.apache.org/r/26715/#comment97120>

    shouldn't this be a hex value?
    
    also, why are the hex values different for linux and apple?



3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
<https://reviews.apache.org/r/26715/#comment97129>

    s/setting/result/ ?


- Vinod Kone


On Oct. 15, 2014, 12:24 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26715/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 12:24 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This patch allows us to use O_CLOEXEC even if it's not available on some distributions.
> 
> Will follow up with a patch to cleanup the code.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp ec41fe412290a152a15a49e091f0bc6436e42cfd 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 898d175980e397493270454aafdf340a96c9cf85 
> 
> Diff: https://reviews.apache.org/r/26715/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> both on mac and linux
> 
> 
> Thanks,
> 
> Jie Yu
> 
>