[jira] [Commented] (HIVE-9582) HCatalog should use IMetaStoreClient interface

["Thejas M Nair (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-9582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14522183#comment-14522183 ] 

Thejas M Nair commented on HIVE-9582:
-------------------------------------


Looks good . +1 pending tests. 
Just a minor nit -  Regarding the deprecation annotation, it would be useful to add the alternate function as part of deprecation message (its much quicker to parse than entire function description).

Example -
@deprecated use {@link #new()} instead. 

> HCatalog should use IMetaStoreClient interface
> ----------------------------------------------
>
>                 Key: HIVE-9582
>                 URL: https://issues.apache.org/jira/browse/HIVE-9582
>             Project: Hive
>          Issue Type: Sub-task
>          Components: HCatalog, Metastore
>    Affects Versions: 0.14.0, 0.13.1
>            Reporter: Thiruvel Thirumoolan
>            Assignee: Thiruvel Thirumoolan
>              Labels: hcatalog, metastore, rolling_upgrade
>         Attachments: HIVE-9582.1.patch, HIVE-9582.2.patch, HIVE-9582.3.patch, HIVE-9582.4.patch, HIVE-9582.5.patch, HIVE-9582.6.patch, HIVE-9583.1.patch
>
>
> Hive uses IMetaStoreClient and it makes using RetryingMetaStoreClient easy. Hence during a failure, the client retries and possibly succeeds. But HCatalog has long been using HiveMetaStoreClient directly and hence failures are costly, especially if they are during the commit stage of a job. Its also not possible to do rolling upgrade of MetaStore Server.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)