[GitHub] [pinot] richardstartin commented on a change in pull request #7402: Faster association between Java Class and PinotDataType

[GitBox <gi...@apache.org>]

richardstartin commented on a change in pull request #7402:
URL: https://github.com/apache/pinot/pull/7402#discussion_r703821420



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java
##########
@@ -1119,13 +1160,11 @@ public PinotDataType getSingleValueType() {
   }
 
   public static PinotDataType getSingleValueType(Class<?> cls) {
-    PinotDataType pdt = SINGLE_VALUE_TYPE_MAP.get(cls);
-    return (pdt != null) ? pdt : OBJECT;
+    return null == cls ? OBJECT : SINGLE_VALUE_TYPE_MAPPING.apply(cls);

Review comment:
       Actually, null handling is explicitly tested for, which is why the check was added. However, with the latest change (and I suggest we take it or leave it at this point given the limited impact of the change) this is unnecessary.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org