Re: [PR] Use Duration instead of long+TimeUnit in ReadOnlyTStore.unreserve [accumulo]

["DomGarguilo (via GitHub)" <gi...@apache.org>]

DomGarguilo commented on PR #4371:
URL: https://github.com/apache/accumulo/pull/4371#issuecomment-2079797771

   > > I've looked through the changes and they look okay - still trying to workout if the test issues that lead to the revert can be duplicated and assigned a reason.
   > 
   > I also took a quick look at the older commit and could not find what the problem was. I suspect it some time unit conversion issue where the code does something like call sleep with a nanosecond value which basically asking the code sleep forever. However I could not find any issue like that when looking at the change.
   
   I am also not sure where the problem was coming from. Do you think its safe to merge this in and open a new ticket if that issue arises again? @EdColeman @keith-turner 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org