You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/06 15:20:45 UTC

[GitHub] [arrow-datafusion] Jimexist edited a comment on pull request #275: add postgres comparison to python test

Jimexist edited a comment on pull request #275:
URL: https://github.com/apache/arrow-datafusion/pull/275#issuecomment-833573089


   > I am wondering whether the SQL integration tests should be part of the Python bindings or just within DataFusion (using the Rust API or some endpoint)? I think there is nothing wrong with having some SQL tests in the Python bindings too, but I would expect if we have a big suite of SQL tests to compare with PostgreSQL, this would be outside of the Python part.
   
   IMO if the python wrapper would be thin, almost always up to date with rust library, and stay that way, having it at the python level makes more sense.
   
   Happy to move this out, but maybe in a separate PR later, when things fledge out more thoroughly?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org