You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/18 21:30:48 UTC

[GitHub] [kafka] rondagostino opened a new pull request #9199: KAFKA-10418: alter topic configs via kafka-topics error text

rondagostino opened a new pull request #9199:
URL: https://github.com/apache/kafka/pull/9199


   Changing a topic config with the `kafka-topics` command while connecting to Kafka via `--bootstrap-server` (rather than connecting to ZooKeeper via `--zookeeper`) is not supported. The desired functionality is available elsewhere, though: it is possible to change a topic config while connecting to Kafka rather than ZooKeeper via the `kafka-configs` command instead. However, neither the `kafka-topics` error message received nor the `kafka-topics` help information itself indicates this other possibility. For example:
   
   ```
   $ kafka-topics.sh --bootstrap-server localhost:9092 --alter --topic test --config flush.messages=12345
   Option combination "[bootstrap-server],[config]" can't be used with option "[alter]"
   ```
   
   ```
   $ kafka-topics.sh
   ...
   --config <String: name=value> A topic configuration override for the topic being created or altered...It is supported only in combination with – create if --bootstrap-server option is used.
   ```
   
   Rather than simply saying that what you want to do isn't available, it would be better to say also that you can do it with the `kafka-configs` command.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] rondagostino commented on pull request #9199: KAFKA-10418: alter topic configs via kafka-topics error text

Posted by GitBox <gi...@apache.org>.
rondagostino commented on pull request #9199:
URL: https://github.com/apache/kafka/pull/9199#issuecomment-676492765


   JDK 11 build failure was a n infrastructure issue.  JDK 8 test failure is an unrelated flaky test (`org.apache.kafka.streams.integration.EosIntegrationTest.shouldNotViolateEosIfOneTaskFailsWithState[exactly_once]`).  JDK 14 build was clean.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] cmccabe commented on pull request #9199: KAFKA-10418: alter topic configs via kafka-topics error text

Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #9199:
URL: https://github.com/apache/kafka/pull/9199#issuecomment-675734800


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] rondagostino commented on pull request #9199: KAFKA-10418: alter topic configs via kafka-topics error text

Posted by GitBox <gi...@apache.org>.
rondagostino commented on pull request #9199:
URL: https://github.com/apache/kafka/pull/9199#issuecomment-675731352


   @cmccabe Can you take a look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] rondagostino commented on pull request #9199: KAFKA-10418: alter topic configs via kafka-topics error text

Posted by GitBox <gi...@apache.org>.
rondagostino commented on pull request #9199:
URL: https://github.com/apache/kafka/pull/9199#issuecomment-677671036


   Actually, it turns out that the ability to use `kafka-configs --bootstrap-server` was only added in 2.5.  So this could be backported to 2.5 and 2.6 (not all the way back to 2.2 as originally stated).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] cmccabe merged pull request #9199: KAFKA-10418: alter topic configs via kafka-topics error text

Posted by GitBox <gi...@apache.org>.
cmccabe merged pull request #9199:
URL: https://github.com/apache/kafka/pull/9199


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] cmccabe commented on pull request #9199: KAFKA-10418: alter topic configs via kafka-topics error text

Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #9199:
URL: https://github.com/apache/kafka/pull/9199#issuecomment-678066207


   Thanks, @rondagostino.
   
   I think it's OK to just have in trunk for now.  We already did a 2.6 release and this is not a critical fix, just a help text change.  But if someone feels strongly I will backport.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] rondagostino commented on pull request #9199: KAFKA-10418: alter topic configs via kafka-topics error text

Posted by GitBox <gi...@apache.org>.
rondagostino commented on pull request #9199:
URL: https://github.com/apache/kafka/pull/9199#issuecomment-676491706


   Note that KIP-377 landed in 2.2 and explicitly stated in the new code that altering topic configurations via `kafka-topics` was deprecated – even using the `--zookeeper` flag (setting topic configs using `kafka-topics` when using `--create` to create a topic is supported and works with --bootstrap-server; it’s just altering/deleting topic configs that was deprecated via `--zookeeper` and that never worked/never will work via `--bootstrap-server`).  Therefore, potentially, this could be backported as far back as 2.2.x.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org