[jira] [Resolved] (HBASE-26063) The current checkcompatibility.py script can not compare master and rel/2.0.0

["Duo Zhang (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-26063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Duo Zhang resolved HBASE-26063.
-------------------------------
    Hadoop Flags: Reviewed
      Resolution: Fixed

Merged to master.

Thanks [~niuyulin] for reviewing.

> The current checkcompatibility.py script can not compare master and rel/2.0.0
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-26063
>                 URL: https://issues.apache.org/jira/browse/HBASE-26063
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Blocker
>             Fix For: 3.0.0-alpha-1
>
>
> There are basically two problems.
> One is the findbugs-maven-plugin, on rel/2.0.0, its version is 3.0.0, and it will lead the below error
> {noformat}
> [ERROR] Failed to execute goal org.codehaus.mojo:findbugs-maven-plugin:3.0.0:findbugs (default) on project hbase: Unable to parse configuration of mojo org.codehaus.mojo:findbugs-maven-plugin:3.0.0:findbugs for parameter pluginArtifacts: Cannot assign configuration entry 'pluginArtifacts' with value '${plugin.artifacts}' of type java.util.Collections.UnmodifiableRandomAccessList to property of type java.util.ArrayList -> [Help 1]
> {noformat}
> The other is because of opentelemetry. It packs some jar in the fat agent jar, and the name of the directory for holding the extracted jar content still ends .jar, which makes the current script think it is a jar and cause problems.
> {noformat}
> java.io.FileNotFoundException: /home/zhangduo/hbase/code/target/compat-check/dst/hbase-assembly/target/dependency/opentelemetry-javaagent-1.0.1-all-jar/META-INF/licenses/okhttp-3.14.9.jar (是一个目录)
>         at java.io.FileInputStream.open0(Native Method)
>         at java.io.FileInputStream.open(FileInputStream.java:195)
>         at java.io.FileInputStream.<init>(FileInputStream.java:138)
>         at java.io.FileInputStream.<init>(FileInputStream.java:93)
>         at sun.tools.jar.Main.run(Main.java:307)
>         at sun.tools.jar.Main.main(Main.java:1288)
> ERROR: can't extract '/home/zhangduo/hbase/code/target/compat-check/dst/hbase-assembly/target/dependency/opentelemetry-javaagent-1.0.1-all-jar/META-INF/licenses/okhttp-3.14.9.jar'
> INFO:root:Results: {}
> Traceback (most recent call last):
>   File "./checkcompatibility.py", line 539, in <module>
>     main()
>   File "./checkcompatibility.py", line 535, in main
>     args.compare_warnings))
>   File "./checkcompatibility.py", line 233, in compare_results
>     if compare_tool_results_count(tool_results, check, issue_type, known_count)]
>   File "./checkcompatibility.py", line 252, in compare_tool_results_count
>     return tool_results[check][issue_type] > known_count
> KeyError: 'binary'
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)