You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@gmail.com> on 2017/01/04 23:10:01 UTC
Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2
model and implementation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54287/
-----------------------------------------------------------
(Updated Jan. 4, 2017, 3:10 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Suma Shivaprasad.
Changes
-------
rebased patch
Bugs: ATLAS-1308
https://issues.apache.org/jira/browse/ATLAS-1308
Repository: atlas
Description
-------
Model and implement the new Discovery REST API's for the following search types:
* DSL Search
* Full Text Search
and retrieve search results in a structured model using AtlasEntityHeader information.
Diffs (updated)
-----
client/src/main/java/org/apache/atlas/AtlasClient.java 154644d
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 94a249c
intg/src/main/java/org/apache/atlas/model/discovery/AtlasDiscoveryService.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 538534f
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 8e086c9
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java PRE-CREATION
repository/src/main/scala/org/apache/atlas/query/Expressions.scala 81be7db
webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/resources/EntityDiscoveryJerseyResourceIT.java PRE-CREATION
Diff: https://reviews.apache.org/r/54287/diff/
Testing
-------
UTs done, tested using POSTMAN rest client.
Thanks,
Sarath Subramanian
Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2
model and implementation
Posted by Sarath Subramanian <sa...@gmail.com>.
> On Jan. 5, 2017, 12:37 a.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java, line 53
> > <https://reviews.apache.org/r/54287/diff/6/?file=1596858#file1596858line53>
> >
> > Would a search-result have values for fields entities/attributes/fullTextResult? If these are mutually exclusive, consider using 3 different constructors - it will be handly to construct with only available attributes.
created a new constructor to set query text and query type. The other variables are set using setters
- Sarath
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54287/#review160566
-----------------------------------------------------------
On Jan. 5, 2017, 5:28 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54287/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2017, 5:28 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1308
> https://issues.apache.org/jira/browse/ATLAS-1308
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Model and implement the new Discovery REST API's for the following search types:
> * DSL Search
> * Full Text Search
> and retrieve search results in a structured model using AtlasEntityHeader information.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/atlas/AtlasClient.java 154644d
> client/src/main/java/org/apache/atlas/AtlasDiscoveryClientV2.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java f026ec6
> intg/src/main/java/org/apache/atlas/model/discovery/AtlasDiscoveryService.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 538534f
> repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 8e086c9
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java PRE-CREATION
> repository/src/main/scala/org/apache/atlas/query/Expressions.scala 81be7db
> webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 9b56c92
> webapp/src/test/java/org/apache/atlas/web/resources/EntityDiscoveryJerseyResourceIT.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/54287/diff/
>
>
> Testing
> -------
>
> UTs done, tested using POSTMAN rest client.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2
model and implementation
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54287/#review160566
-----------------------------------------------------------
Fix it, then Ship it!
client/src/main/java/org/apache/atlas/AtlasClient.java (line 223)
<https://reviews.apache.org/r/54287/#comment231706>
Consider adding V2 REST methods in a separate client class - similar to AtlasEntitiesClientV2, AtlasTypedefClientV2. These methods should return structed data, instead of JSONObject.
intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java (line 53)
<https://reviews.apache.org/r/54287/#comment231707>
Would a search-result have values for fields entities/attributes/fullTextResult? If these are mutually exclusive, consider using 3 different constructors - it will be handly to construct with only available attributes.
intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java (line 74)
<https://reviews.apache.org/r/54287/#comment231708>
This method ends up creating a duplicate list, with size of the exising list. Consider alternate of modifying the exising list, by removing existing entry for newEntity and append.
intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java (line 168)
<https://reviews.apache.org/r/54287/#comment231709>
Why duplicate the list and then append? Consider directly adding to the exising list.
- Madhan Neethiraj
On Jan. 4, 2017, 11:10 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54287/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2017, 11:10 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1308
> https://issues.apache.org/jira/browse/ATLAS-1308
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Model and implement the new Discovery REST API's for the following search types:
> * DSL Search
> * Full Text Search
> and retrieve search results in a structured model using AtlasEntityHeader information.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/atlas/AtlasClient.java 154644d
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 94a249c
> intg/src/main/java/org/apache/atlas/model/discovery/AtlasDiscoveryService.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 538534f
> repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 8e086c9
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java PRE-CREATION
> repository/src/main/scala/org/apache/atlas/query/Expressions.scala 81be7db
> webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/EntityDiscoveryJerseyResourceIT.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/54287/diff/
>
>
> Testing
> -------
>
> UTs done, tested using POSTMAN rest client.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2
model and implementation
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54287/#review160685
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Jan. 6, 2017, 6:37 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54287/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2017, 6:37 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1308
> https://issues.apache.org/jira/browse/ATLAS-1308
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Model and implement the new Discovery REST API's for the following search types:
> * DSL Search
> * Full Text Search
> and retrieve search results in a structured model using AtlasEntityHeader information.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/atlas/AtlasDiscoveryClientV2.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java f026ec6
> intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 538534f
> intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java fc58f58
> repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 8e086c9
> repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/discovery/AtlasLineageService.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 14bf143
> repository/src/main/scala/org/apache/atlas/query/Expressions.scala 81be7db
> webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java 739c6c1
> webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java effd29f
> webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 9b56c92
> webapp/src/test/java/org/apache/atlas/web/resources/EntityDiscoveryJerseyResourceIT.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/54287/diff/
>
>
> Testing
> -------
>
> UTs done, tested using POSTMAN rest client.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2
model and implementation
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54287/
-----------------------------------------------------------
(Updated Jan. 5, 2017, 10:37 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Suma Shivaprasad.
Changes
-------
moved the interface class of lineage and discovery to server side
Bugs: ATLAS-1308
https://issues.apache.org/jira/browse/ATLAS-1308
Repository: atlas
Description
-------
Model and implement the new Discovery REST API's for the following search types:
* DSL Search
* Full Text Search
and retrieve search results in a structured model using AtlasEntityHeader information.
Diffs (updated)
-----
client/src/main/java/org/apache/atlas/AtlasDiscoveryClientV2.java PRE-CREATION
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java f026ec6
intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 538534f
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java fc58f58
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 8e086c9
repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java PRE-CREATION
repository/src/main/java/org/apache/atlas/discovery/AtlasLineageService.java PRE-CREATION
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java PRE-CREATION
repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 14bf143
repository/src/main/scala/org/apache/atlas/query/Expressions.scala 81be7db
webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java 739c6c1
webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java effd29f
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 9b56c92
webapp/src/test/java/org/apache/atlas/web/resources/EntityDiscoveryJerseyResourceIT.java PRE-CREATION
Diff: https://reviews.apache.org/r/54287/diff/
Testing
-------
UTs done, tested using POSTMAN rest client.
Thanks,
Sarath Subramanian
Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2
model and implementation
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54287/
-----------------------------------------------------------
(Updated Jan. 5, 2017, 8:44 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Suma Shivaprasad.
Changes
-------
addressed review comments and moved to org.apache.atlas.discovery package
Bugs: ATLAS-1308
https://issues.apache.org/jira/browse/ATLAS-1308
Repository: atlas
Description
-------
Model and implement the new Discovery REST API's for the following search types:
* DSL Search
* Full Text Search
and retrieve search results in a structured model using AtlasEntityHeader information.
Diffs (updated)
-----
client/src/main/java/org/apache/atlas/AtlasDiscoveryClientV2.java PRE-CREATION
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java f026ec6
intg/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java PRE-CREATION
intg/src/main/java/org/apache/atlas/discovery/AtlasSearchResult.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 538534f
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 8e086c9
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java PRE-CREATION
repository/src/main/scala/org/apache/atlas/query/Expressions.scala 81be7db
webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 9b56c92
webapp/src/test/java/org/apache/atlas/web/resources/EntityDiscoveryJerseyResourceIT.java PRE-CREATION
Diff: https://reviews.apache.org/r/54287/diff/
Testing
-------
UTs done, tested using POSTMAN rest client.
Thanks,
Sarath Subramanian
Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2
model and implementation
Posted by Sarath Subramanian <sa...@gmail.com>.
> On Jan. 5, 2017, 6:28 p.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/model/discovery/AtlasDiscoveryService.java, line 24
> > <https://reviews.apache.org/r/54287/diff/7/?file=1598211#file1598211line24>
> >
> > "org.apache.atlas.model" package does not seem a good place to for service interfaces. Please move the service definition to server side.
moved to org.apache.atlas.discovery package
> On Jan. 5, 2017, 6:28 p.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java, line 136
> > <https://reviews.apache.org/r/54287/diff/7/?file=1598212#file1598212line136>
> >
> > no implementation for these 3 methods? Please review.
forgot to remove these empty methods. Not implementing these methods, since using setters for setting entities, attributes and fulltextresults for search results. Created a new constructor that uses queryText and queryType.
> On Jan. 5, 2017, 6:28 p.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java, line 178
> > <https://reviews.apache.org/r/54287/diff/7/?file=1598212#file1598212line178>
> >
> > It may not be useful to prevent duplicate names in the list.. as entries values will have to be in sync. Consider removing this check and simply add the given name. In fact, it will be better for this class to not support addName() method.
removed the addName()
- Sarath
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54287/#review160665
-----------------------------------------------------------
On Jan. 5, 2017, 8:44 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54287/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2017, 8:44 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1308
> https://issues.apache.org/jira/browse/ATLAS-1308
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Model and implement the new Discovery REST API's for the following search types:
> * DSL Search
> * Full Text Search
> and retrieve search results in a structured model using AtlasEntityHeader information.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/atlas/AtlasDiscoveryClientV2.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java f026ec6
> intg/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/discovery/AtlasSearchResult.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 538534f
> repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 8e086c9
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java PRE-CREATION
> repository/src/main/scala/org/apache/atlas/query/Expressions.scala 81be7db
> webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 9b56c92
> webapp/src/test/java/org/apache/atlas/web/resources/EntityDiscoveryJerseyResourceIT.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/54287/diff/
>
>
> Testing
> -------
>
> UTs done, tested using POSTMAN rest client.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2
model and implementation
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54287/#review160665
-----------------------------------------------------------
client/src/main/java/org/apache/atlas/AtlasClient.java
<https://reviews.apache.org/r/54287/#comment231848>
Only white-space changes in this file. Can you please revert?
intg/src/main/java/org/apache/atlas/model/discovery/AtlasDiscoveryService.java (line 24)
<https://reviews.apache.org/r/54287/#comment231856>
"org.apache.atlas.model" package does not seem a good place to for service interfaces. Please move the service definition to server side.
intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java (line 136)
<https://reviews.apache.org/r/54287/#comment231849>
no implementation for these 3 methods? Please review.
intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java (line 174)
<https://reviews.apache.org/r/54287/#comment231851>
Consider changing this to "if (names == null)".
intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java (line 178)
<https://reviews.apache.org/r/54287/#comment231853>
It may not be useful to prevent duplicate names in the list.. as entries values will have to be in sync. Consider removing this check and simply add the given name. In fact, it will be better for this class to not support addName() method.
intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java (line 190)
<https://reviews.apache.org/r/54287/#comment231854>
Use of 'currentValues' may not be required. Please review and consider directly using "this.values".
- Madhan Neethiraj
On Jan. 6, 2017, 1:28 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54287/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2017, 1:28 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1308
> https://issues.apache.org/jira/browse/ATLAS-1308
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Model and implement the new Discovery REST API's for the following search types:
> * DSL Search
> * Full Text Search
> and retrieve search results in a structured model using AtlasEntityHeader information.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/atlas/AtlasClient.java 154644d
> client/src/main/java/org/apache/atlas/AtlasDiscoveryClientV2.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java f026ec6
> intg/src/main/java/org/apache/atlas/model/discovery/AtlasDiscoveryService.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 538534f
> repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 8e086c9
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java PRE-CREATION
> repository/src/main/scala/org/apache/atlas/query/Expressions.scala 81be7db
> webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 9b56c92
> webapp/src/test/java/org/apache/atlas/web/resources/EntityDiscoveryJerseyResourceIT.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/54287/diff/
>
>
> Testing
> -------
>
> UTs done, tested using POSTMAN rest client.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2
model and implementation
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54287/
-----------------------------------------------------------
(Updated Jan. 5, 2017, 5:28 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Suma Shivaprasad.
Changes
-------
* addressed review comments
* added new client for discovery APIs
Bugs: ATLAS-1308
https://issues.apache.org/jira/browse/ATLAS-1308
Repository: atlas
Description
-------
Model and implement the new Discovery REST API's for the following search types:
* DSL Search
* Full Text Search
and retrieve search results in a structured model using AtlasEntityHeader information.
Diffs (updated)
-----
client/src/main/java/org/apache/atlas/AtlasClient.java 154644d
client/src/main/java/org/apache/atlas/AtlasDiscoveryClientV2.java PRE-CREATION
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java f026ec6
intg/src/main/java/org/apache/atlas/model/discovery/AtlasDiscoveryService.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 538534f
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 8e086c9
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java PRE-CREATION
repository/src/main/scala/org/apache/atlas/query/Expressions.scala 81be7db
webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 9b56c92
webapp/src/test/java/org/apache/atlas/web/resources/EntityDiscoveryJerseyResourceIT.java PRE-CREATION
Diff: https://reviews.apache.org/r/54287/diff/
Testing
-------
UTs done, tested using POSTMAN rest client.
Thanks,
Sarath Subramanian