You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/01 14:00:23 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #33890: [SPARK-36442][DOCS] Remove UserDefinedAggregateFunction reference

cloud-fan commented on a change in pull request #33890:
URL: https://github.com/apache/spark/pull/33890#discussion_r700242765



##########
File path: docs/sql-ref-syntax-ddl-create-function.md
##########
@@ -74,7 +74,6 @@ CREATE [ OR REPLACE ] [ TEMPORARY ] FUNCTION [ IF NOT EXISTS ]
     * Should extend `UDF` or `UDAF` in `org.apache.hadoop.hive.ql.exec` package.
     * Should extend `AbstractGenericUDAFResolver`, `GenericUDF`, or
       `GenericUDTF` in `org.apache.hadoop.hive.ql.udf.generic` package.
-    * Should extend `UserDefinedAggregateFunction` in `org.apache.spark.sql.expressions` package.

Review comment:
       Shall we mention `Aggregator` as it's the new API to define native Spark UDAFs?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org