You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/07/21 00:38:38 UTC
[GitHub] [hbase] ndimiduk opened a new pull request #2108: Backport "HBASE-24658 Update PolicyBasedChaosMonkey to handle uncaught exceptions" to branch-1
ndimiduk opened a new pull request #2108:
URL: https://github.com/apache/hbase/pull/2108
Running `ServerKillingChaosMonkey` via `RESTApiClusterManager` for any
duration of time slowly leaks region servers. I see failures on the
RESTApi side go unreported on the ChaosMonkey side. It seems like
`RuntimeException`s are being thrown and lost.
`PolicyBasedChaosMonkey` uses a primitive means of thread management
anyway. Update to use a thread pool, thread groups, and an
uncaughtExceptionHandler.
Signed-off-by: Bharath Vissapragada <bh...@apache.org>
Signed-off-by: Viraj Jasani <vj...@apache.org>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk merged pull request #2108: Backport "HBASE-24658 Update PolicyBasedChaosMonkey to handle uncaught exceptions" to branch-1
Posted by GitBox <gi...@apache.org>.
ndimiduk merged pull request #2108:
URL: https://github.com/apache/hbase/pull/2108
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #2108: Backport "HBASE-24658 Update PolicyBasedChaosMonkey to handle uncaught exceptions" to branch-1
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on pull request #2108:
URL: https://github.com/apache/hbase/pull/2108#issuecomment-661495721
Posted a patch for buildbot, as I'm out of practice on branch-1. FYI @bharathv , @virajjasani in case you want to see the backport. Shouldn't be anything surprising here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2108: Backport "HBASE-24658 Update PolicyBasedChaosMonkey to handle uncaught exceptions" to branch-1
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2108:
URL: https://github.com/apache/hbase/pull/2108#issuecomment-661555293
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 13s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 55s | branch-1 passed |
| +1 :green_heart: | compile | 0m 21s | branch-1 passed with JDK v1.8.0_252 |
| +1 :green_heart: | compile | 0m 28s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 0m 41s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 21s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 28s | branch-1 passed with JDK v1.8.0_252 |
| +1 :green_heart: | javadoc | 0m 16s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 4m 10s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 0m 0s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 5s | the patch passed |
| +1 :green_heart: | compile | 0m 21s | the patch passed with JDK v1.8.0_252 |
| +1 :green_heart: | javac | 0m 21s | the patch passed |
| +1 :green_heart: | compile | 0m 27s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | javac | 0m 27s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 31s | hbase-it: The patch generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 3m 8s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 58s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 13s | the patch passed with JDK v1.8.0_252 |
| +1 :green_heart: | javadoc | 0m 17s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 0m 0s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 23s | hbase-it in the patch passed. |
| +1 :green_heart: | asflicense | 0m 22s | The patch does not generate ASF License warnings. |
| | | 34m 5s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2108/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2108 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 0dba2c076a2d 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-2108/out/precommit/personality/provided.sh |
| git revision | branch-1 / d697c40 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_252 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2108/2/testReport/ |
| Max. process+thread count | 479 (vs. ulimit of 10000) |
| modules | C: hbase-it U: hbase-it |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2108/2/console |
| versions | git=1.9.1 maven=3.0.5 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2108: Backport "HBASE-24658 Update PolicyBasedChaosMonkey to handle uncaught exceptions" to branch-1
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2108:
URL: https://github.com/apache/hbase/pull/2108#issuecomment-661530909
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 11m 53s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 53s | branch-1 passed |
| +1 :green_heart: | compile | 0m 21s | branch-1 passed with JDK v1.8.0_252 |
| +1 :green_heart: | compile | 0m 27s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 0m 41s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 20s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 27s | branch-1 passed with JDK v1.8.0_252 |
| +1 :green_heart: | javadoc | 0m 14s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 4m 7s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 0m 0s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 6s | the patch passed |
| +1 :green_heart: | compile | 0m 21s | the patch passed with JDK v1.8.0_252 |
| +1 :green_heart: | javac | 0m 21s | the patch passed |
| +1 :green_heart: | compile | 0m 27s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | javac | 0m 27s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 31s | hbase-it: The patch generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 3m 5s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 2s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 12s | the patch passed with JDK v1.8.0_252 |
| +1 :green_heart: | javadoc | 0m 15s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 0m 0s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 10s | hbase-it in the patch passed. |
| +1 :green_heart: | asflicense | 0m 20s | The patch does not generate ASF License warnings. |
| | | 44m 21s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2108/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2108 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 4e20d1980392 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-2108/out/precommit/personality/provided.sh |
| git revision | branch-1 / d697c40 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_252 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2108/1/testReport/ |
| Max. process+thread count | 481 (vs. ulimit of 10000) |
| modules | C: hbase-it U: hbase-it |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2108/1/console |
| versions | git=1.9.1 maven=3.0.5 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org