You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/12/14 06:15:53 UTC
[GitHub] jerrypeng commented on a change in pull request #3184: remove
pulsar-client-schema (WIP)
jerrypeng commented on a change in pull request #3184: remove pulsar-client-schema (WIP)
URL: https://github.com/apache/pulsar/pull/3184#discussion_r241652727
##########
File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/schema/Field.java
##########
@@ -40,4 +33,42 @@
*/
private final int index;
+ public Field(String name, int index) {
Review comment:
Then I will have to pull in the lombok dependency. Didn't feel appropriate. Trying to keep pulsar-client-api as minimal as possible
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services