You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/05 08:22:45 UTC
[GitHub] [pulsar] sijia-w opened a new pull request #11927: [docs] [ISSUE 11805] Add topic lookup metrics
sijia-w opened a new pull request #11927:
URL: https://github.com/apache/pulsar/pull/11927
Fixes #11805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #11927: [docs] [ISSUE 11805] Add topic lookup metrics
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #11927:
URL: https://github.com/apache/pulsar/pull/11927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11927: [docs] [ISSUE 11805] Add topic lookup metrics
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #11927:
URL: https://github.com/apache/pulsar/pull/11927#discussion_r757198358
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
##########
@@ -730,7 +730,7 @@ private void updateBundleSplitMetrics(Set<String> bundlesToBeSplit) {
}
private static final Summary selectBrokerForAssignment = Summary.build(
- "pulsar_broker_load_manager_bundle_assigment", "-")
+ "pulsar_broker_load_manager_bundle_assignment", "-")
Review comment:
Hi @sijia-w, confirmed w/ @gaoran10, please do not modify the code files since they may be referenced somewhere. Can you revert this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijia-w commented on pull request #11927: [docs] [ISSUE 11805] Add topic lookup metrics
Posted by GitBox <gi...@apache.org>.
sijia-w commented on pull request #11927:
URL: https://github.com/apache/pulsar/pull/11927#issuecomment-928989577
@merlimat Can you please explain a bit what `metricspulsar_broker_load_manager_bundle_assignment` and `pulsar_broker_topic_load_pending_request` do? By the way, is there a label for lookup metrics in `broker.conf` file? I appreciate your quick response. Many thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijia-w commented on pull request #11927: [docs] [ISSUE 11805] Add topic lookup metrics
Posted by GitBox <gi...@apache.org>.
sijia-w commented on pull request #11927:
URL: https://github.com/apache/pulsar/pull/11927#issuecomment-913626579
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a change in pull request #11927: [docs] [ISSUE 11805] Add topic lookup metrics
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on a change in pull request #11927:
URL: https://github.com/apache/pulsar/pull/11927#discussion_r754094589
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
##########
@@ -730,7 +730,7 @@ private void updateBundleSplitMetrics(Set<String> bundlesToBeSplit) {
}
private static final Summary selectBrokerForAssignment = Summary.build(
- "pulsar_broker_load_manager_bundle_assigment", "-")
+ "pulsar_broker_load_manager_bundle_assignment", "-")
Review comment:
I'm not sure we need to modify this indicator name, because maybe someone use this name somewhere. /cc @merlimat PLTA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11927: [docs] [ISSUE 11805] Add topic lookup metrics
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #11927:
URL: https://github.com/apache/pulsar/pull/11927#discussion_r703115443
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
##########
@@ -730,7 +730,7 @@ private void updateBundleSplitMetrics(Set<String> bundlesToBeSplit) {
}
private static final Summary selectBrokerForAssignment = Summary.build(
- "pulsar_broker_load_manager_bundle_assigment", "-")
+ "pulsar_broker_load_manager_bundle_assignment", "-")
Review comment:
@sijia-w please confirm this change with engineer, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijia-w commented on pull request #11927: [docs] [ISSUE 11805] Add topic lookup metrics
Posted by GitBox <gi...@apache.org>.
sijia-w commented on pull request #11927:
URL: https://github.com/apache/pulsar/pull/11927#issuecomment-928989577
@merlimat Can you please explain a bit what `metricspulsar_broker_load_manager_bundle_assignment` and `pulsar_broker_topic_load_pending_request` do? By the way, is there a label for lookup metrics in `broker.conf` file? I appreciate your quick response. Many thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijia-w commented on pull request #11927: [docs] [ISSUE 11805] Add topic lookup metrics
Posted by GitBox <gi...@apache.org>.
sijia-w commented on pull request #11927:
URL: https://github.com/apache/pulsar/pull/11927#issuecomment-913109081
@merlimat Can you please explain a bit what metrics`pulsar_broker_load_manager_bundle_assignment` and `pulsar_broker_topic_load_pending_request` do? By the way, is there a label for lookup metrics in `broker.conf` file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org