You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@arrow.apache.org by James Duong <ja...@bitquilltech.com.INVALID> on 2022/08/02 20:01:00 UTC
[FlightSQL][JDBC] Additional changes to the JDBC driver
Hi,
We have a few additional important changes for the Flight SQL JDBC Driver:
- Avoid sending headers for built-in properties such as hostname, port.
- Make handling of connection URI key names and Properties keys
case-insensitive.
- Create separate FlightClients for each new endpoint returned by
getFlightInfo.
(https://github.com/rafael-telles/arrow/pulls)
Now that we have the Flight SQL JDBC driver merged under the
flight-jdbc-driver branch, should we make PRs against
apache/flight-jdbc-driver for these changes and create JIRAs? Should we no
longer write to the rafael-telles/flight-jdbc-driver branch?
--
*James Duong*
Lead Software Developer
Bit Quill Technologies Inc.
Direct: +1.604.562.6082 | jamesd@bitquilltech.com
https://www.bitquilltech.com
This email message is for the sole use of the intended recipient(s) and may
contain confidential and privileged information. Any unauthorized review,
use, disclosure, or distribution is prohibited. If you are not the
intended recipient, please contact the sender by reply email and destroy
all copies of the original message. Thank you.
Re: [FlightSQL][JDBC] Additional changes to the JDBC driver
Posted by David Li <li...@apache.org>.
We did merge the cleared IP into a branch:
https://github.com/apache/arrow/tree/flight-sql-jdbc
James then took it and filed a PR, which we can review:
https://github.com/apache/arrow/pull/13800
So long as further changes build on top of that commit, I guess we can just include them in the existing PR - but for reviewability's sake it might be good to create a separate PR for large changes?
-David
On Fri, Aug 5, 2022, at 17:12, Wes McKinney wrote:
> If you want to merge the cleared IP into a new branch rather than
> master, that is fine, too. It's not necessary to land it in the main
> branch
>
> On Tue, Aug 2, 2022 at 4:18 PM David Li <li...@apache.org> wrote:
>>
>> Would it be OK to get what's there into the main branch first? i.e., open a PR from the apache/flight-jdbc-driver (or a contributor's clone of it, that would make it easier to address review comments). I'd like to get through the review of what we currently have since the PR will be large. And then changes can target the main branch (if you want to open PRs for the changes now, I suppose they could just be stacked on top?)
>>
>> On Tue, Aug 2, 2022, at 16:01, James Duong wrote:
>> > Hi,
>> >
>> > We have a few additional important changes for the Flight SQL JDBC Driver:
>> > - Avoid sending headers for built-in properties such as hostname, port.
>> > - Make handling of connection URI key names and Properties keys
>> > case-insensitive.
>> > - Create separate FlightClients for each new endpoint returned by
>> > getFlightInfo.
>> > (https://github.com/rafael-telles/arrow/pulls)
>> >
>> > Now that we have the Flight SQL JDBC driver merged under the
>> > flight-jdbc-driver branch, should we make PRs against
>> > apache/flight-jdbc-driver for these changes and create JIRAs? Should we no
>> > longer write to the rafael-telles/flight-jdbc-driver branch?
>> >
>> > --
>> >
>> > *James Duong*
>> > Lead Software Developer
>> > Bit Quill Technologies Inc.
>> > Direct: +1.604.562.6082 | jamesd@bitquilltech.com
>> > https://www.bitquilltech.com
>> >
>> > This email message is for the sole use of the intended recipient(s) and may
>> > contain confidential and privileged information. Any unauthorized review,
>> > use, disclosure, or distribution is prohibited. If you are not the
>> > intended recipient, please contact the sender by reply email and destroy
>> > all copies of the original message. Thank you.
Re: [FlightSQL][JDBC] Additional changes to the JDBC driver
Posted by Wes McKinney <we...@gmail.com>.
If you want to merge the cleared IP into a new branch rather than
master, that is fine, too. It's not necessary to land it in the main
branch
On Tue, Aug 2, 2022 at 4:18 PM David Li <li...@apache.org> wrote:
>
> Would it be OK to get what's there into the main branch first? i.e., open a PR from the apache/flight-jdbc-driver (or a contributor's clone of it, that would make it easier to address review comments). I'd like to get through the review of what we currently have since the PR will be large. And then changes can target the main branch (if you want to open PRs for the changes now, I suppose they could just be stacked on top?)
>
> On Tue, Aug 2, 2022, at 16:01, James Duong wrote:
> > Hi,
> >
> > We have a few additional important changes for the Flight SQL JDBC Driver:
> > - Avoid sending headers for built-in properties such as hostname, port.
> > - Make handling of connection URI key names and Properties keys
> > case-insensitive.
> > - Create separate FlightClients for each new endpoint returned by
> > getFlightInfo.
> > (https://github.com/rafael-telles/arrow/pulls)
> >
> > Now that we have the Flight SQL JDBC driver merged under the
> > flight-jdbc-driver branch, should we make PRs against
> > apache/flight-jdbc-driver for these changes and create JIRAs? Should we no
> > longer write to the rafael-telles/flight-jdbc-driver branch?
> >
> > --
> >
> > *James Duong*
> > Lead Software Developer
> > Bit Quill Technologies Inc.
> > Direct: +1.604.562.6082 | jamesd@bitquilltech.com
> > https://www.bitquilltech.com
> >
> > This email message is for the sole use of the intended recipient(s) and may
> > contain confidential and privileged information. Any unauthorized review,
> > use, disclosure, or distribution is prohibited. If you are not the
> > intended recipient, please contact the sender by reply email and destroy
> > all copies of the original message. Thank you.
Re: [FlightSQL][JDBC] Additional changes to the JDBC driver
Posted by David Li <li...@apache.org>.
Would it be OK to get what's there into the main branch first? i.e., open a PR from the apache/flight-jdbc-driver (or a contributor's clone of it, that would make it easier to address review comments). I'd like to get through the review of what we currently have since the PR will be large. And then changes can target the main branch (if you want to open PRs for the changes now, I suppose they could just be stacked on top?)
On Tue, Aug 2, 2022, at 16:01, James Duong wrote:
> Hi,
>
> We have a few additional important changes for the Flight SQL JDBC Driver:
> - Avoid sending headers for built-in properties such as hostname, port.
> - Make handling of connection URI key names and Properties keys
> case-insensitive.
> - Create separate FlightClients for each new endpoint returned by
> getFlightInfo.
> (https://github.com/rafael-telles/arrow/pulls)
>
> Now that we have the Flight SQL JDBC driver merged under the
> flight-jdbc-driver branch, should we make PRs against
> apache/flight-jdbc-driver for these changes and create JIRAs? Should we no
> longer write to the rafael-telles/flight-jdbc-driver branch?
>
> --
>
> *James Duong*
> Lead Software Developer
> Bit Quill Technologies Inc.
> Direct: +1.604.562.6082 | jamesd@bitquilltech.com
> https://www.bitquilltech.com
>
> This email message is for the sole use of the intended recipient(s) and may
> contain confidential and privileged information. Any unauthorized review,
> use, disclosure, or distribution is prohibited. If you are not the
> intended recipient, please contact the sender by reply email and destroy
> all copies of the original message. Thank you.