[GitHub] [spark] HyukjinKwon commented on a diff in pull request #37335: [SPARK-39895][SQL][PYTHON][R] Support multiple column drop

[GitBox <gi...@apache.org>]

HyukjinKwon commented on code in PR #37335:
URL: https://github.com/apache/spark/pull/37335#discussion_r940858205


##########
R/pkg/R/DataFrame.R:
##########
@@ -3593,17 +3593,27 @@ setMethod("str",
 #' drop(df, "col1")
 #' drop(df, c("col1", "col2"))
 #' drop(df, df$col1)
+#' drop(df, list(df$col1, df$col2))
 #' }
 #' @note drop since 2.0.0
 setMethod("drop",
           signature(x = "SparkDataFrame"),
           function(x, col) {

Review Comment:
   should probably use a different siganture with `...`. Feel free to remove this in this PR, and do it in another PR if you're not used to this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org