You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by "Song Ziyang (Jira)" <ji...@apache.org> on 2023/03/27 17:40:00 UTC

[jira] [Commented] (RATIS-1823) Improve error log in StreamObserverWithTimeout

    [ https://issues.apache.org/jira/browse/RATIS-1823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705475#comment-17705475 ] 

Song Ziyang commented on RATIS-1823:
------------------------------------

Since the Request is a generic type,  it is uneasy to filter the data field off. [~szetszwo] Could you please take a look at this, thanks in advance :)

> Improve error log in StreamObserverWithTimeout
> ----------------------------------------------
>
>                 Key: RATIS-1823
>                 URL: https://issues.apache.org/jira/browse/RATIS-1823
>             Project: Ratis
>          Issue Type: Improvement
>          Components: gRPC, snapshot
>            Reporter: Song Ziyang
>            Priority: Major
>
> In StreamObserverWithTimeout's LOG, Request body is fully printed , e.g. https://github.com/apache/ratis/blob/d495846f0b754a67594cc48f5559ca36838fd700/ratis-grpc/src/main/java/org/apache/ratis/grpc/util/StreamObserverWithTimeout.java#L85. 
> However, the installSnapshot requests are sometimes large and even reach multiple megabytes (maxChunkSize). Print the whole request is cpu-consuming and annoying. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)