You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/01 10:59:38 UTC
[GitHub] [incubator-nuttx] povauboin opened a new pull request #684:
boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
povauboin opened a new pull request #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
URL: https://github.com/apache/incubator-nuttx/pull/684
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #684:
boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
URL: https://github.com/apache/incubator-nuttx/pull/684#discussion_r403769275
##########
File path: boards/arm/stm32h7/stm32h747i-disco/src/stm32_sdmmc.c
##########
@@ -0,0 +1,175 @@
+/****************************************************************************
+ * boards/arm/stm32h7/stm32h747i-disco/src/stm32_sdmmc.c
+ *
+ * Copyright (C) 2016-2019 Gregory Nutt. All rights reserved.
+ * Author: Gregory Nutt <gn...@nuttx.org>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
Review comment:
New files should have Apache license. Please copy the text from [here](https://github.com/apache/incubator-nuttx/blob/master/sched/sched/sched_getcpu.c)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] justinmclean commented on issue #684:
boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
Posted by GitBox <gi...@apache.org>.
justinmclean commented on issue #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
URL: https://github.com/apache/incubator-nuttx/pull/684#issuecomment-613377365
Hi,
How exactly has this license changed? Has the "PX4 Development Team” given permission and submitted a software grant?
Thanks,
Justin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #684:
boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on issue #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
URL: https://github.com/apache/incubator-nuttx/pull/684#issuecomment-614838793
Was this file created just for NuttX? Does it have a history as a PX4 file that is being brought into NuttX? In this latter case, there this a license issue. I don't think that the author has the authority to change the license.
On the other hand, If the file was created specifically for NuttX and has never been a part of PX4, then I would say that the creator of the file simply put the wrong license on the file due to a lack of understanding of the license requirements. In this latter case, it is just a legitimate error and not really a license issue since it was never a part of PX4. However, if this is the case, then you probably should amend the commit so that it does not appear that it was a PX4 file that has had its license inappropriately changed.
If merged as is, then this will forever appear to be a licensing problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] povauboin commented on a change in pull request
#684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and
FAT FS
Posted by GitBox <gi...@apache.org>.
povauboin commented on a change in pull request #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
URL: https://github.com/apache/incubator-nuttx/pull/684#discussion_r408050465
##########
File path: boards/arm/stm32h7/stm32h747i-disco/src/stm32_dma_alloc.c
##########
@@ -0,0 +1,117 @@
+/****************************************************************************
+ * boards/arm/stm32h7/stm32h747i-disco/src/stm32_dma_alloc.c
+ *
+ * Copyright (C) 2016 PX4 Development Team. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
Review comment:
license is now changed to Apache
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and
FAT FS
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
URL: https://github.com/apache/incubator-nuttx/pull/684#discussion_r403770790
##########
File path: boards/arm/stm32h7/stm32h747i-disco/src/stm32_dma_alloc.c
##########
@@ -0,0 +1,117 @@
+/****************************************************************************
+ * boards/arm/stm32h7/stm32h747i-disco/src/stm32_dma_alloc.c
+ *
+ * Copyright (C) 2016 PX4 Development Team. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
Review comment:
When you contribute software to NuttX you are literally giving it to the Apached Software Foundation and must have the Apache license.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and
FAT FS
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
URL: https://github.com/apache/incubator-nuttx/pull/684#discussion_r403770652
##########
File path: boards/arm/stm32h7/stm32h747i-disco/src/stm32_sdmmc.c
##########
@@ -0,0 +1,175 @@
+/****************************************************************************
+ * boards/arm/stm32h7/stm32h747i-disco/src/stm32_sdmmc.c
+ *
+ * Copyright (C) 2016-2019 Gregory Nutt. All rights reserved.
+ * Author: Gregory Nutt <gn...@nuttx.org>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
Review comment:
No, we cannot bring any new 3rd party code into the repository. We can never do that unless they provide a software grant (SGA).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #684:
boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
URL: https://github.com/apache/incubator-nuttx/pull/684#issuecomment-614845994
Please have a look at @patacongo https://github.com/apache/incubator-nuttx/search?q=stm32_dma_alloc.c&unscoped_q=stm32_dma_alloc.c,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and
FAT FS
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
URL: https://github.com/apache/incubator-nuttx/pull/684#discussion_r403770652
##########
File path: boards/arm/stm32h7/stm32h747i-disco/src/stm32_sdmmc.c
##########
@@ -0,0 +1,175 @@
+/****************************************************************************
+ * boards/arm/stm32h7/stm32h747i-disco/src/stm32_sdmmc.c
+ *
+ * Copyright (C) 2016-2019 Gregory Nutt. All rights reserved.
+ * Author: Gregory Nutt <gn...@nuttx.org>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
Review comment:
No, we cannot bring any new 3rd party code into the repository. We can never do that unless they provide a software grant (SGA).
So, no, I can't give any approval. It is impossible to use this code without the proper Apache license.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #684:
boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
URL: https://github.com/apache/incubator-nuttx/pull/684#issuecomment-614581424
@davids5 should we merge this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #684:
boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
URL: https://github.com/apache/incubator-nuttx/pull/684#discussion_r403769486
##########
File path: boards/arm/stm32h7/stm32h747i-disco/src/stm32_sdmmc.c
##########
@@ -0,0 +1,175 @@
+/****************************************************************************
+ * boards/arm/stm32h7/stm32h747i-disco/src/stm32_sdmmc.c
+ *
+ * Copyright (C) 2016-2019 Gregory Nutt. All rights reserved.
+ * Author: Gregory Nutt <gn...@nuttx.org>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
Review comment:
@patacongo Could you please give your explicit approval for this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and
FAT FS
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
URL: https://github.com/apache/incubator-nuttx/pull/684#discussion_r403771526
##########
File path: boards/arm/stm32h7/stm32h747i-disco/src/stm32_sdmmc.c
##########
@@ -0,0 +1,175 @@
+/****************************************************************************
+ * boards/arm/stm32h7/stm32h747i-disco/src/stm32_sdmmc.c
+ *
+ * Copyright (C) 2016-2019 Gregory Nutt. All rights reserved.
+ * Author: Gregory Nutt <gn...@nuttx.org>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
Review comment:
Ahh... talking with Abdelatif, I missunderstood the question. I am the copyright holder and the old SDMMC code and do give my approval to change the license header to the Apache 2.0 license header cited above.
The one with the PX4 copyright must also have an Apache 2.0 header to be considered.
BTW: The current version of my original SDMMC file does now have an Apache header and also includes requires changes that you do not have in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] povauboin commented on issue #684:
boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
Posted by GitBox <gi...@apache.org>.
povauboin commented on issue #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
URL: https://github.com/apache/incubator-nuttx/pull/684#issuecomment-613379477
I copied the file from ./boards/arm/stm32/nucleo-f429zi/src/stm32_dma_alloc.c which has apache license
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #684:
boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
URL: https://github.com/apache/incubator-nuttx/pull/684#discussion_r403769200
##########
File path: boards/arm/stm32h7/stm32h747i-disco/src/stm32_dma_alloc.c
##########
@@ -0,0 +1,117 @@
+/****************************************************************************
+ * boards/arm/stm32h7/stm32h747i-disco/src/stm32_dma_alloc.c
+ *
+ * Copyright (C) 2016 PX4 Development Team. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
Review comment:
New files should have Apache license. Please copy the text from [here](https://github.com/apache/incubator-nuttx/blob/master/sched/sched/sched_getcpu.c)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #684:
boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
URL: https://github.com/apache/incubator-nuttx/pull/684#issuecomment-614805293
@xiaoxiang781216 as I understand it there is an unresolved License issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #684:
boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
URL: https://github.com/apache/incubator-nuttx/pull/684#issuecomment-614838793
Was this file created just for NuttX? Does it have a history as a PX4 file that is being brought into NuttX? In this latter case, there this a license issue. I don't think that the author has the authority to change the license.
On the other hand, If the file was created specifically for NuttX and has never been a part of PX4, then I would say that the creator of the file simply put the wrong license on the file due to a lack of understanding of the license requirements. In this latter case, it is just a legitimate error and not really a license issue since it was never a part of PX4. However, if this is the case, then you probably should amend the commit so that it does not appear that it was a PX4 file that has had its license inappropriately changed.
If merged as is, then this will forever be a licensing problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #684:
boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
URL: https://github.com/apache/incubator-nuttx/pull/684#discussion_r403771404
##########
File path: boards/arm/stm32h7/stm32h747i-disco/src/stm32_sdmmc.c
##########
@@ -0,0 +1,175 @@
+/****************************************************************************
+ * boards/arm/stm32h7/stm32h747i-disco/src/stm32_sdmmc.c
+ *
+ * Copyright (C) 2016-2019 Gregory Nutt. All rights reserved.
+ * Author: Gregory Nutt <gn...@nuttx.org>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
Review comment:
I meant the approval to change the license to Apache.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] povauboin commented on a change in pull request
#684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and
FAT FS
Posted by GitBox <gi...@apache.org>.
povauboin commented on a change in pull request #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
URL: https://github.com/apache/incubator-nuttx/pull/684#discussion_r408050543
##########
File path: boards/arm/stm32h7/stm32h747i-disco/src/stm32_sdmmc.c
##########
@@ -0,0 +1,175 @@
+/****************************************************************************
+ * boards/arm/stm32h7/stm32h747i-disco/src/stm32_sdmmc.c
+ *
+ * Copyright (C) 2016-2019 Gregory Nutt. All rights reserved.
+ * Author: Gregory Nutt <gn...@nuttx.org>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
Review comment:
license is now changed to Apache
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and
FAT FS
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
URL: https://github.com/apache/incubator-nuttx/pull/684#discussion_r403770546
##########
File path: boards/arm/stm32h7/stm32h747i-disco/src/stm32_dma_alloc.c
##########
@@ -0,0 +1,117 @@
+/****************************************************************************
+ * boards/arm/stm32h7/stm32h747i-disco/src/stm32_dma_alloc.c
+ *
+ * Copyright (C) 2016 PX4 Development Team. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
Review comment:
No 3rd party licensed code is permitted in Apache repositorys. This cannot be merged without the Apache license header with no author and no copyright.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on issue #684:
URL: https://github.com/apache/incubator-nuttx/pull/684#issuecomment-618394053
> Please have a look at @patacongo https://github.com/apache/incubator-nuttx/search?q=stm32_dma_alloc.c&unscoped_q=stm32_dma_alloc.c,
@davids5 can PX4 team give us the permission to chagne the copyright? Otherwise, this PR will block forever.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] povauboin commented on pull request #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
Posted by GitBox <gi...@apache.org>.
povauboin commented on pull request #684:
URL: https://github.com/apache/incubator-nuttx/pull/684#issuecomment-630783628
@patacongo sorry I missed the emails in the flow. Thanks for resolving the conflict.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #684:
URL: https://github.com/apache/incubator-nuttx/pull/684#issuecomment-629407856
NOTE: I would have been happy to resolve this conflict for you. But I do not have access to your branch. The default action when creating a PR is to allow maintainers to modify your branch. But since I have no priveleges in your branch, I cannot do that for you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #684:
URL: https://github.com/apache/incubator-nuttx/pull/684#issuecomment-618394053
> Please have a look at @patacongo https://github.com/apache/incubator-nuttx/search?q=stm32_dma_alloc.c&unscoped_q=stm32_dma_alloc.c,
Can PX4 team give us the permission to chagne the copyright? Otherwise, this PR will block forever.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #684:
URL: https://github.com/apache/incubator-nuttx/pull/684#issuecomment-629407220
@povauboin It looks to me this PR is ready to be merged. But now, there is a conflict with the version of arch/arm/src/stm32h7/stm32_sdmmc.c on your branch and the version in the upstream master.
Can you please resolve and and I promise to merge ASAP.
Also.. could you please squash the commits into one or two?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #684:
URL: https://github.com/apache/incubator-nuttx/pull/684#issuecomment-629407856
NOTE: I would have been happy to resolve this conflict for you. But I do not have access to your branch. The default action when creating a PR is to allow maintainers to modify your branch but apparently you unchecked that? Since I have no priveleges in your branch, I cannot resolve the conflict for you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo closed pull request #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
Posted by GitBox <gi...@apache.org>.
patacongo closed pull request #684:
URL: https://github.com/apache/incubator-nuttx/pull/684
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #684:
URL: https://github.com/apache/incubator-nuttx/pull/684#issuecomment-629488565
@povauboin I fixed the conflict. But since your branch is protected I had create a new branch and rebase with master to fix the conflict. This PR is now replaced with #1056
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #684:
URL: https://github.com/apache/incubator-nuttx/pull/684#issuecomment-629386622
Can this be merged? It is passing all of the checks. I see no references to any unacceptable header files. Is there any remaining show stopper on this? If no, I will merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org