You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by pnowojski <gi...@git.apache.org> on 2017/08/24 09:47:40 UTC
[GitHub] flink pull request #4577: Add user context and bind together state fields in...
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/4577
Add user context and bind together state fields in TwoPhaseCommitSinkFunction
This PR extends public API of `PublicEvolving` class, that hasn't been yet released.
Existing tests in `TwoPhaseCommitSinkFunctionTest` cover this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pnowojski/flink 2phase
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4577.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4577
----
commit 14ffd356c0c6f4b16d99d2742914eeab2c5e26c2
Author: Piotr Nowojski <pi...@gmail.com>
Date: 2017-08-21T14:43:26Z
[FLINK-7498][streaming] Bind together state fields of TwoPhaseCommitSinkFunction
Make sure that state fields are coupled together between checkpoints.
commit 962dce30ea159f2bf612510507d7f842081d29d7
Author: Piotr Nowojski <pi...@gmail.com>
Date: 2017-08-21T14:53:07Z
[FLINK-7497][streaming] Introduce user context in TwoPhaseCommitSinkFunction
commit 044db26f492a852b828922627959996ca67684a6
Author: Piotr Nowojski <pi...@gmail.com>
Date: 2017-08-14T13:45:45Z
[hotfix][streaming] Allow to override methods from TwoPhaseCommitSinkFunction
This allow for some custom user logic during handling checkpoints.
commit 6ee8a50df7ffc6eb5ee8cfc28af93009669faaab
Author: Piotr Nowojski <pi...@gmail.com>
Date: 2017-08-22T14:06:33Z
[hotfix][streaming] Fix logging in TwoPhaseCommitSinkFunction
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4577: Add user context and bind together state fields in TwoPha...
Posted by pnowojski <gi...@git.apache.org>.
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/4577
Thanks! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4577: Add user context and bind together state fields in...
Posted by pnowojski <gi...@git.apache.org>.
Github user pnowojski closed the pull request at:
https://github.com/apache/flink/pull/4577
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4577: Add user context and bind together state fields in TwoPha...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4577
I merged this. 👌
Could you please close the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4577: Add user context and bind together state fields in...
Posted by pnowojski <gi...@git.apache.org>.
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4577#discussion_r135202467
--- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java ---
@@ -304,4 +287,33 @@ private String name() {
getRuntimeContext().getIndexOfThisSubtask(),
getRuntimeContext().getNumberOfParallelSubtasks());
}
+
+ /**
+ * State POJO class coupling pendingTransaction, context and pendingCommitTransactions.
--- End diff --
Added default constructor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4577: Add user context and bind together state fields in...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4577#discussion_r135037286
--- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java ---
@@ -304,4 +287,33 @@ private String name() {
getRuntimeContext().getIndexOfThisSubtask(),
getRuntimeContext().getNumberOfParallelSubtasks());
}
+
+ /**
+ * State POJO class coupling pendingTransaction, context and pendingCommitTransactions.
--- End diff --
This is not technically a Flink POJO because there is no zero-argument constructor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---