You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/01/01 14:59:00 UTC

[jira] [Commented] (AIRFLOW-6418) Remove SystemTest.skip decorator

    [ https://issues.apache.org/jira/browse/AIRFLOW-6418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006428#comment-17006428 ] 

ASF GitHub Bot commented on AIRFLOW-6418:
-----------------------------------------

mik-laj commented on pull request #6991: [AIRFLOW-6418] Remove SystemTest.skip decorator
URL: https://github.com/apache/airflow/pull/6991
 
 
   Instead of forcing the user to use a decorator, we can override the "run" method in the class.
   
   
   - [X] Description above provides context of the change
   - [X] Commit message contains [\[AIRFLOW-6418\]](https://issues.apache.org/jira/browse/AIRFLOW-6418) or `[AIRFLOW-6418]` for document-only changes
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [X] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove SystemTest.skip decorator
> --------------------------------
>
>                 Key: AIRFLOW-6418
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6418
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: tests
>    Affects Versions: 1.10.7
>            Reporter: Kamil Bregula
>            Priority: Major
>
> Instead of forcing the user to use a decorator, we can override the "run" method in the class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)