[jira] [Commented] (CASSANDRA-10559) Support encrypted and plain traffic on the same port

["Robert Stupp (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-10559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14967649#comment-14967649 ] 

Robert Stupp commented on CASSANDRA-10559:
------------------------------------------

Formal review of the patch looks good!

I think the patch is against trunk (applies cleanly to 3.0 and trunk)? I've setup branches for 3.0 and trunk to get [CI results|http://cassci.datastax.com/search/?q=snazy-10559-] shortly.

IMO the change itself is difficult to test with unit tests since we do not have SSL support in {{CQLTester}} (yet). But can you add some enhancements to {{NativeTransportServiceTest}} to test that at least both the optional and non-optional variants start and stop correctly? Can you also provide some dtest enhancement in {{native_transport_ssl_test.py}}?

> Support encrypted and plain traffic on the same port
> ----------------------------------------------------
>
>                 Key: CASSANDRA-10559
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10559
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>         Attachments: 0001-CASSANDRA-8803-Allow-to-serve-plain-and-encrypted-na.patch
>
>
> To be able to migrate clusters in a rolling way from plain to encrypted traffic it would be very helpful if we could have Cassandra accept both on the same port. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)