You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2015/12/02 20:25:07 UTC
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-1006 Random error dur...
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/167
TINKERPOP3-1006 Random error during builds: shouldReloadClassLoaderWhileDoingEvalInSeparateThread()ATINKERPOP3-1006 Random error during builds: shouldReloadClassLoaderWhileDoingEvalInSeparateThread()
Adjust tests to be a bit more bulletproof with respect to thread timing. Not sure if i've fixed anything with this change as these tests have never failed for me on my system. I would have CTR'd this but I'd like to see if there is any validation that this is working correctly now. I guess runs in Travis and those who have macs would be the best judge of whether or not this issue is resolved.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-1006
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/167.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #167
----
commit 87201658f2023c725d4620b4a700b949605099a7
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2015-12-02T19:20:30Z
Adjust tests to be a bit more bulletproof with respect to thread timing.
Not sure if i've fixed anything with this change as these tests have never failed for me on my system.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-1006 Random error dur...
Posted by PommeVerte <gi...@git.apache.org>.
Github user PommeVerte commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/167#issuecomment-161662961
This correctly builds here. I haven't had problems recently so I can't really tell if this is fixed or not. I suspect that travis will complain if it isn't. This loosens things a bit so VOTE: +1 from me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-1006 Random error dur...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/167
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-1006 Random error dur...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/167#issuecomment-161657953
I never had this test fail for me. Thus, your loosening only makes it LESS likely to fail for me :).
VOTE +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-1006 Random error dur...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/167#issuecomment-161753504
Travis looks happy with this - so we'll assume fixed - until it isn't. merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---