You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by wa...@apache.org on 2022/07/30 18:13:35 UTC

[echarts-examples] branch gh-pages updated: fix(explore): fix NPE

This is an automated email from the ASF dual-hosted git repository.

wangzx pushed a commit to branch gh-pages
in repository https://gitbox.apache.org/repos/asf/echarts-examples.git


The following commit(s) were added to refs/heads/gh-pages by this push:
     new b6a1d68e fix(explore): fix NPE
b6a1d68e is described below

commit b6a1d68e4031518593c5ab84f98f40d9736af01c
Author: plainheart <yh...@all-my-life.cn>
AuthorDate: Sun Jul 31 02:12:49 2022 +0800

    fix(explore): fix NPE
---
 package-lock.json       | 13 +------------
 package.json            |  1 -
 src/explore/Explore.vue |  2 +-
 3 files changed, 2 insertions(+), 14 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 9c4d4381..52537e8d 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -15,7 +15,6 @@
         "nanoid": "^4.0.0",
         "prettier": "^2.7.1",
         "resize-detector": "^0.3.0",
-        "scroll-into-view": "^1.14.2",
         "semver": "^7.3.7",
         "sucrase": "^3.24.0",
         "vanilla-lazyload": "^17.8.3",
@@ -55,7 +54,7 @@
         "sassjs-loader": "^2.0.0",
         "seedrandom": "^3.0.5",
         "sharp": "^0.30.5",
-        "shelljs": "^0.8.4",
+        "shelljs": "^0.8.5",
         "style-loader": "^2.0.0",
         "typescript": "^4.1.3",
         "vue": "2.6.14",
@@ -8752,11 +8751,6 @@
         "url": "https://opencollective.com/webpack"
       }
     },
-    "node_modules/scroll-into-view": {
-      "version": "1.15.0",
-      "resolved": "https://registry.npmjs.org/scroll-into-view/-/scroll-into-view-1.15.0.tgz",
-      "integrity": "sha512-Ytbg8O1GlN8vOOZMPDOrjXixAFXZ4oJklxHkYREqdUFYo+a8qVuPX16U3nRkifKnM8kkvY9sOy7EL30HaeW07Q=="
-    },
     "node_modules/section-matter": {
       "version": "1.0.0",
       "resolved": "https://registry.npmjs.org/section-matter/-/section-matter-1.0.0.tgz",
@@ -17723,11 +17717,6 @@
         "ajv-keywords": "^3.4.1"
       }
     },
-    "scroll-into-view": {
-      "version": "1.15.0",
-      "resolved": "https://registry.npmjs.org/scroll-into-view/-/scroll-into-view-1.15.0.tgz",
-      "integrity": "sha512-Ytbg8O1GlN8vOOZMPDOrjXixAFXZ4oJklxHkYREqdUFYo+a8qVuPX16U3nRkifKnM8kkvY9sOy7EL30HaeW07Q=="
-    },
     "section-matter": {
       "version": "1.0.0",
       "resolved": "https://registry.npmjs.org/section-matter/-/section-matter-1.0.0.tgz",
diff --git a/package.json b/package.json
index ffcf5e51..447bc5d8 100644
--- a/package.json
+++ b/package.json
@@ -69,7 +69,6 @@
     "nanoid": "^4.0.0",
     "prettier": "^2.7.1",
     "resize-detector": "^0.3.0",
-    "scroll-into-view": "^1.14.2",
     "semver": "^7.3.7",
     "sucrase": "^3.24.0",
     "vanilla-lazyload": "^17.8.3",
diff --git a/src/explore/Explore.vue b/src/explore/Explore.vue
index 1900023e..70607cac 100644
--- a/src/explore/Explore.vue
+++ b/src/explore/Explore.vue
@@ -237,7 +237,7 @@ export default {
 
   methods: {
     onActiveNavChanged(event, currentItem, lastActiveItem) {
-      if (!event) {
+      if (!event || !currentItem) {
         return;
       }
       // change url


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org