You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/11/07 02:16:35 UTC
[GitHub] [incubator-uniffle] amaliujia opened a new pull request, #305: [ISSUE-290] Make RpcNodePort and HttpNodePort optional
amaliujia opened a new pull request, #305:
URL: https://github.com/apache/incubator-uniffle/pull/305
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://github.com/Tencent/Firestorm/blob/master/CONTRIBUTING.md
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR makes `RPC_SERVER_PORT` and `JETTY_HTTP_PORT` in RSS conf as optional by setting up default values into the config entries.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Feature.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released versions or within the unreleased branches such as master.
If no, write 'No'.
-->
NO
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #305: [ISSUE-290] Make RpcNodePort and HttpNodePort optional
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #305:
URL: https://github.com/apache/incubator-uniffle/pull/305#issuecomment-1305003006
We only provide the default value in the configuration. https://github.com/apache/incubator-uniffle/blob/master/conf/server.conf and https://github.com/apache/incubator-uniffle/blob/master/conf/coordinator.conf
```
rss.rpc.server.port 19999
rss.jetty.http.port 19998
```
`design.md` is only the Kubernetes Operator design document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] amaliujia commented on pull request #305: [ISSUE-290] Make RpcNodePort and HttpNodePort optional
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #305:
URL: https://github.com/apache/incubator-uniffle/pull/305#issuecomment-1304998806
The `design.md` in fact mentions two values for each port config entry:
```
# RpcNodePort represents the port required by the rpc protocol of the coordinators,
# and the range is the same as the port range of the NodePort type service in kubernetes.
# By default, we will deploy two coordinators to ensure active-active.
rpcNodePort:
- 30001
- 30011
# httpNodePort represents the port required by the http protocol of the coordinators,
# and the range is the same as the port range of the NodePort type service in kubernetes.
# By default, we will deploy two coordinators to ensure active-active.
httpNodePort:
- 30002
- 30012
```
However I didn't see two usages in the codebase. Maybe I have missed something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] amaliujia commented on pull request #305: [ISSUE-290] Make RpcNodePort and HttpNodePort optional
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #305:
URL: https://github.com/apache/incubator-uniffle/pull/305#issuecomment-1305004650
I see it better now. Made a change to have the default value in config entries match the values in the provided config file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #305: [ISSUE-290] Make RpcNodePort and HttpNodePort optional
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #305:
URL: https://github.com/apache/incubator-uniffle/pull/305#issuecomment-1305013433
# [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/305?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#305](https://codecov.io/gh/apache/incubator-uniffle/pull/305?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d63d191) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/fbe307481f57cdc97816a207c2640281612d95c6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fbe3074) will **not change** coverage.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #305 +/- ##
=========================================
Coverage 60.70% 60.70%
Complexity 1459 1459
=========================================
Files 180 180
Lines 9223 9223
Branches 886 886
=========================================
Hits 5599 5599
Misses 3325 3325
Partials 299 299
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/305?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/uniffle/common/config/RssBaseConf.java](https://codecov.io/gh/apache/incubator-uniffle/pull/305/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9jb25maWcvUnNzQmFzZUNvbmYuamF2YQ==) | `93.42% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi merged pull request #305: [ISSUE-290] Make RpcNodePort and HttpNodePort optional
Posted by GitBox <gi...@apache.org>.
jerqi merged PR #305:
URL: https://github.com/apache/incubator-uniffle/pull/305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #305: [ISSUE-290] Make RpcNodePort and HttpNodePort optional
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #305:
URL: https://github.com/apache/incubator-uniffle/pull/305#issuecomment-1316570264
Do you want to join our `Wechat` group? You can scan the QR code
<img width="414" alt="企业微信截图_eb8711db-34bf-4365-bdab-15ef2e3ea119" src="https://user-images.githubusercontent.com/8159038/202124870-c8c69a8a-569d-4c64-894d-cc79f9099070.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org