[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #5057: Create fcd folder on local storage in VMware vSphere

[GitBox <gi...@apache.org>]

harikrishna-patnala commented on a change in pull request #5057:
URL: https://github.com/apache/cloudstack/pull/5057#discussion_r642739744



##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -6183,6 +6183,8 @@ public Type getType() {
                         dsMo.setCustomFieldValue(CustomFieldConstants.CLOUD_UUID, poolUuid);
                     }
 

Review comment:
       Currently, we are creating this folder in two places, 1. modifystoragepool command and 2. initialize local storage.
   I think solidfire is not covered in these two places.
   We need to see the right place for solidfire. The folder creation in PR #4977 may work but it is a kind of hack to check the folder existence upon an operation, ideally, it has to create when MS initialises the storage. Let me know if you know such a place otherwise, I'll incorporate the changes made in #4977 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org