You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2023/09/07 09:04:56 UTC
Review Request 74582: RANGER-4398: security-zone API enhancements to support incremental updates and resource pagination
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74582/
-----------------------------------------------------------
Review request for ranger, Anand Nadar, Abhay Kulkarni, Mehul Parikh, Monika Kachhadiya, Pradeep Agrawal, Ramesh Mani, Subhrat Chaudhary, and Velmurugan Periasamy.
Bugs: RANGER-4398
https://issues.apache.org/jira/browse/RANGER-4398
Repository: ranger
Description
-------
- updated RangerSecurityZone with additional of following fields for each resource: id, createdBy/Time, updatedBy/Time
- introduced RangerSecurityZoneV2, a wrapper over RangerSecurityZone, to make it easier for incremental changes
- added following REST APIs and corresponding Python APIs:
-- POST /service/public/v2/api/zones-v2
-- PUT /service/public/v2/api/zones-v2
-- GET /service/public/v2/api/zones-v2
-- GET /service/public/v2/api/zones-v2/name/{name}
-- GET /service/public/v2/api/zones-v2/{id}
-- PUT /service/public/v2/api/zones-v2/resources/name/{name}/{serviceName}
-- DELETE /service/public/v2/api/zones-v2/resources/name/{name}/{serviceName}
-- GET /service/public/v2/api/zones-v2/resources/name/{name}/{serviceName}
-- PUT /service/public/v2/api/zones-v2/resources/{id}/{serviceName}
-- DELETE /service/public/v2/api/zones-v2/resources/{id}/{serviceName}
-- GET /service/public/v2/api/zones-v2/resources/{id}/{serviceName}
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPrincipal.java PRE-CREATION
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZone.java 71d64ca83
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZoneV2.java PRE-CREATION
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerSecurityZoneHelper.java PRE-CREATION
intg/src/main/python/apache_ranger/client/ranger_client.py 484a42128
intg/src/main/python/apache_ranger/model/ranger_base.py 2111534d0
intg/src/main/python/apache_ranger/model/ranger_principal.py PRE-CREATION
intg/src/main/python/apache_ranger/model/ranger_security_zone.py 6faa15744
intg/src/main/python/setup.py 0a4b1c66e
security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java cd906ed22
security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 55d6aaac5
Diff: https://reviews.apache.org/r/74582/diff/1/
Testing
-------
- verified that new REST APIs work correctly using Python scripts
- verified that all existing tests pass successfully
Thanks,
Madhan Neethiraj
Re: Review Request 74582: RANGER-4398: security-zone API enhancements to support incremental updates and resource pagination
Posted by Asit Vadhavkar via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74582/#review225725
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java
Lines 262 (patched)
<https://reviews.apache.org/r/74582/#comment314169>
If the {id} is the zone id can the path be changed to : /api/zone-v2/{id}/service/{serviceName}/resources ?
- Asit Vadhavkar
On Sept. 7, 2023, 9:04 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74582/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2023, 9:04 a.m.)
>
>
> Review request for ranger, Anand Nadar, Abhay Kulkarni, Mehul Parikh, Monika Kachhadiya, Pradeep Agrawal, Ramesh Mani, Subhrat Chaudhary, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-4398
> https://issues.apache.org/jira/browse/RANGER-4398
>
>
> Repository: ranger
>
>
> Description
> -------
>
> - updated RangerSecurityZone with additional of following fields for each resource: id, createdBy/Time, updatedBy/Time
> - introduced RangerSecurityZoneV2, a wrapper over RangerSecurityZone, to support partial updates
> - added following REST APIs and corresponding Python APIs:
> -- POST /service/public/v2/api/zones-v2
> -- PUT /service/public/v2/api/zones-v2/{id}
> -- PUT /service/public/v2/api/zones-v2/partial/{id}
> -- GET /service/public/v2/api/zones-v2
> -- GET /service/public/v2/api/zones-v2/name/{name}
> -- GET /service/public/v2/api/zones-v2/{id}
> -- GET /service/public/v2/api/zones-v2/resources/name/{name}/{serviceName}
> -- GET /service/public/v2/api/zones-v2/resources/{id}/{serviceName}
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPrincipal.java PRE-CREATION
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZone.java 71d64ca83
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZoneV2.java PRE-CREATION
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerSecurityZoneHelper.java PRE-CREATION
> intg/src/main/python/apache_ranger/client/ranger_client.py 484a42128
> intg/src/main/python/apache_ranger/model/ranger_base.py 2111534d0
> intg/src/main/python/apache_ranger/model/ranger_principal.py PRE-CREATION
> intg/src/main/python/apache_ranger/model/ranger_security_zone.py 6faa15744
> intg/src/main/python/setup.py 0a4b1c66e
> ranger-examples/sample-client/src/main/python/security_zone_v2.py PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java cd906ed22
> security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 55d6aaac5
>
>
> Diff: https://reviews.apache.org/r/74582/diff/2/
>
>
> Testing
> -------
>
> - verified that new REST APIs work correctly using Python scripts (included in this patch)
> - verified that all existing tests pass successfully
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 74582: RANGER-4398: security-zone API enhancements to support incremental updates and resource pagination
Posted by Selvamohan Neethiraj <sn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74582/#review225749
-----------------------------------------------------------
Ship it!
Ship It!
- Selvamohan Neethiraj
On Sept. 8, 2023, 12:28 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74582/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2023, 12:28 p.m.)
>
>
> Review request for ranger, Anand Nadar, Abhay Kulkarni, Mehul Parikh, Monika Kachhadiya, Pradeep Agrawal, Ramesh Mani, Subhrat Chaudhary, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-4398
> https://issues.apache.org/jira/browse/RANGER-4398
>
>
> Repository: ranger
>
>
> Description
> -------
>
> - updated RangerSecurityZone with additional of following fields for each resource: id, createdBy/Time, updatedBy/Time
> - introduced RangerSecurityZoneV2, a wrapper over RangerSecurityZone, to support partial updates
> - added following REST APIs and corresponding Python APIs:
> -- POST /service/public/v2/api/zones-v2
> -- PUT /service/public/v2/api/zones-v2/{id}
> -- PUT /service/public/v2/api/zones-v2/{id}/partial
> -- GET /service/public/v2/api/zones-v2
> -- GET /service/public/v2/api/zones-v2/name/{name}
> -- GET /service/public/v2/api/zones-v2/{id}
> -- GET /service/public/v2/api/zones-v2/name/{name}/resources/{serviceName}
> -- GET /service/public/v2/api/zones-v2/{id}/resources/{serviceName}
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPrincipal.java PRE-CREATION
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZone.java 71d64ca83
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZoneV2.java PRE-CREATION
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerSecurityZoneHelper.java PRE-CREATION
> intg/src/main/python/apache_ranger/client/ranger_client.py 484a42128
> intg/src/main/python/apache_ranger/model/ranger_base.py 2111534d0
> intg/src/main/python/apache_ranger/model/ranger_principal.py PRE-CREATION
> intg/src/main/python/apache_ranger/model/ranger_security_zone.py 6faa15744
> intg/src/main/python/setup.py 0a4b1c66e
> ranger-examples/sample-client/src/main/python/security_zone_v2.py PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java cd906ed22
> security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 55d6aaac5
>
>
> Diff: https://reviews.apache.org/r/74582/diff/4/
>
>
> Testing
> -------
>
> - verified that new REST APIs work correctly using Python scripts (included in this patch)
> - verified that all existing tests pass successfully
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 74582: RANGER-4398: security-zone API enhancements to support incremental updates and resource pagination
Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74582/#review225753
-----------------------------------------------------------
Ship it!
Ship It!
- Don Bosco Durai
On Sept. 8, 2023, 4:28 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74582/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2023, 4:28 p.m.)
>
>
> Review request for ranger, Anand Nadar, Abhay Kulkarni, Mehul Parikh, Monika Kachhadiya, Pradeep Agrawal, Ramesh Mani, Subhrat Chaudhary, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-4398
> https://issues.apache.org/jira/browse/RANGER-4398
>
>
> Repository: ranger
>
>
> Description
> -------
>
> - updated RangerSecurityZone with additional of following fields for each resource: id, createdBy/Time, updatedBy/Time
> - introduced RangerSecurityZoneV2, a wrapper over RangerSecurityZone, to support partial updates
> - added following REST APIs and corresponding Python APIs:
> -- POST /service/public/v2/api/zones-v2
> -- PUT /service/public/v2/api/zones-v2/{id}
> -- PUT /service/public/v2/api/zones-v2/{id}/partial
> -- GET /service/public/v2/api/zones-v2
> -- GET /service/public/v2/api/zones-v2/name/{name}
> -- GET /service/public/v2/api/zones-v2/{id}
> -- GET /service/public/v2/api/zones-v2/name/{name}/resources/{serviceName}
> -- GET /service/public/v2/api/zones-v2/{id}/resources/{serviceName}
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPrincipal.java PRE-CREATION
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZone.java 71d64ca83
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZoneV2.java PRE-CREATION
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerSecurityZoneHelper.java PRE-CREATION
> intg/src/main/python/apache_ranger/client/ranger_client.py 484a42128
> intg/src/main/python/apache_ranger/model/ranger_base.py 2111534d0
> intg/src/main/python/apache_ranger/model/ranger_principal.py PRE-CREATION
> intg/src/main/python/apache_ranger/model/ranger_security_zone.py 6faa15744
> intg/src/main/python/setup.py 0a4b1c66e
> ranger-examples/sample-client/src/main/python/security_zone_v2.py PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java cd906ed22
> security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 55d6aaac5
>
>
> Diff: https://reviews.apache.org/r/74582/diff/4/
>
>
> Testing
> -------
>
> - verified that new REST APIs work correctly using Python scripts (included in this patch)
> - verified that all existing tests pass successfully
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 74582: RANGER-4398: security-zone API enhancements to support incremental updates and resource pagination
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74582/
-----------------------------------------------------------
(Updated Sept. 8, 2023, 4:28 p.m.)
Review request for ranger, Anand Nadar, Abhay Kulkarni, Mehul Parikh, Monika Kachhadiya, Pradeep Agrawal, Ramesh Mani, Subhrat Chaudhary, and Velmurugan Periasamy.
Changes
-------
addressed review comments
Bugs: RANGER-4398
https://issues.apache.org/jira/browse/RANGER-4398
Repository: ranger
Description
-------
- updated RangerSecurityZone with additional of following fields for each resource: id, createdBy/Time, updatedBy/Time
- introduced RangerSecurityZoneV2, a wrapper over RangerSecurityZone, to support partial updates
- added following REST APIs and corresponding Python APIs:
-- POST /service/public/v2/api/zones-v2
-- PUT /service/public/v2/api/zones-v2/{id}
-- PUT /service/public/v2/api/zones-v2/partial/{id}
-- GET /service/public/v2/api/zones-v2
-- GET /service/public/v2/api/zones-v2/name/{name}
-- GET /service/public/v2/api/zones-v2/{id}
-- GET /service/public/v2/api/zones-v2/resources/name/{name}/{serviceName}
-- GET /service/public/v2/api/zones-v2/resources/{id}/{serviceName}
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPrincipal.java PRE-CREATION
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZone.java 71d64ca83
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZoneV2.java PRE-CREATION
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerSecurityZoneHelper.java PRE-CREATION
intg/src/main/python/apache_ranger/client/ranger_client.py 484a42128
intg/src/main/python/apache_ranger/model/ranger_base.py 2111534d0
intg/src/main/python/apache_ranger/model/ranger_principal.py PRE-CREATION
intg/src/main/python/apache_ranger/model/ranger_security_zone.py 6faa15744
intg/src/main/python/setup.py 0a4b1c66e
ranger-examples/sample-client/src/main/python/security_zone_v2.py PRE-CREATION
security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java cd906ed22
security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 55d6aaac5
Diff: https://reviews.apache.org/r/74582/diff/3/
Changes: https://reviews.apache.org/r/74582/diff/2-3/
Testing
-------
- verified that new REST APIs work correctly using Python scripts (included in this patch)
- verified that all existing tests pass successfully
Thanks,
Madhan Neethiraj