You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/06/16 07:46:12 UTC

[GitHub] [hudi] shenh062326 commented on pull request #1732: [HUDI-1004] Support update metrics in HoodieDeltaStreamerMetrics

shenh062326 commented on pull request #1732:
URL: https://github.com/apache/hudi/pull/1732#issuecomment-644594672


   > Understand the issue originates from `MetricRegistry` not allowing update value for existing metric. By the class design, it does enforce the immutable nature of it. A clean impl. could be to update `Gauge<T>` itself. I see `MetricsSource<T>` is wrapping the update logic to serve a similar purpose, which is fine.
   > 
   > After some searching, I found that there is a recent upstream PR to implement the "settable" version of `Gauge`
   > [dropwizard/metrics#1599](https://github.com/dropwizard/metrics/pull/1599)
   > which seems to solve the problem right away.
   > 
   > IMO we should wait for the upstream change and make small adjustment by using the `SettableGauge`. WDYT?
   
   I feel ok, but I’m not sure when it will be resolved.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org