Re: [PR] [MPOM-453] Disable annotation processing by compiler [maven-parent]

["slawekjaranowski (via GitHub)" <gi...@apache.org>]

slawekjaranowski commented on code in PR #157:
URL: https://github.com/apache/maven-parent/pull/157#discussion_r1653276430


##########
pom.xml:
##########
@@ -945,6 +945,8 @@ under the License.
     <javaVersion>8</javaVersion>
     <maven.compiler.source>${javaVersion}</maven.compiler.source>
     <maven.compiler.target>${javaVersion}</maven.compiler.target>
+    <!-- in order to restore default annotation processing behaviour, please override with empty value -->
+    <maven.compiler.proc>none</maven.compiler.proc>

Review Comment:
   ups ... 
   ```
   % git diff
   diff --git a/pom.xml b/pom.xml
   index e5e60d9..2072a86 100644
   --- a/pom.xml
   +++ b/pom.xml
   @@ -68,6 +68,7 @@
        <mavenVersion>3.6.3</mavenVersion>
        <resolverVersion>1.4.1</resolverVersion>
        <project.build.outputTimestamp>2024-06-02T15:17:10Z</project.build.outputTimestamp>
   +    <maven.compiler.proc />
      </properties>
   ```
   
   ```
   mvn -V clean compile 
   Apache Maven 3.9.8 (36645f6c9b5079805ea5009217e36f2cffd34256)
   
   ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project maven-help-plugin: Fatal error compiling: error: invalid flag: -proc: -> [Help 1]
   ```
   
   ```
   mvn -V clean compile      
   Apache Maven 4.0.0-beta-3 (e92f645c2749eb2a4f5a8843cf01e7441e4b559f)
   
   [INFO] BUILD SUCCESS
   ```
   
   by default I use Maven 4 ....
   so comment is wrong 😖 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org