You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2017/04/09 05:28:04 UTC
[2/2] incubator-impala git commit: IMPALA-5183: increase write wait
timeout in BufferedBlockMgrTest
IMPALA-5183: increase write wait timeout in BufferedBlockMgrTest
The timeout was set low enough that some kind of hardware/system
hiccup had a reasonable chance of causing occasional failures.
Bumped it to 10s - that should only fail if something is seriously
wrong.
Change-Id: Ibbe81eda916730445ca5cf667480ee0cf6b5d429
Reviewed-on: http://gerrit.cloudera.org:8080/6595
Reviewed-by: Matthew Jacobs <mj...@cloudera.com>
Tested-by: Impala Public Jenkins
Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/8146532b
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/8146532b
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/8146532b
Branch: refs/heads/master
Commit: 8146532b640eef012623a4ef107743f1bfc41cdd
Parents: a827e9e
Author: Tim Armstrong <ta...@cloudera.com>
Authored: Fri Apr 7 14:47:12 2017 -0700
Committer: Impala Public Jenkins <im...@gerrit.cloudera.org>
Committed: Sat Apr 8 23:09:37 2017 +0000
----------------------------------------------------------------------
be/src/runtime/buffered-block-mgr-test.cc | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/8146532b/be/src/runtime/buffered-block-mgr-test.cc
----------------------------------------------------------------------
diff --git a/be/src/runtime/buffered-block-mgr-test.cc b/be/src/runtime/buffered-block-mgr-test.cc
index bd60a2c..65fd168 100644
--- a/be/src/runtime/buffered-block-mgr-test.cc
+++ b/be/src/runtime/buffered-block-mgr-test.cc
@@ -61,8 +61,9 @@ const string SCRATCH_DIR = "/tmp/impala-scratch";
// This suffix is appended to a tmp dir
const string SCRATCH_SUFFIX = "/impala-scratch";
-// Number of millieconds to wait to ensure write completes
-const static int WRITE_WAIT_MILLIS = 500;
+// Number of millieconds to wait to ensure write completes. We don't know for sure how
+// slow the disk will be, so this is much higher than we expect the writes to take.
+const static int WRITE_WAIT_MILLIS = 10000;
// How often to check for write completion
const static int WRITE_CHECK_INTERVAL_MILLIS = 10;