You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "tmortagne (via GitHub)" <gi...@apache.org> on 2024/01/11 14:03:42 UTC
[PR] VELOCITY-970: velocity-engine-core contains commons-io Maven descriptor [velocity-engine]
tmortagne opened a new pull request, #37:
URL: https://github.com/apache/velocity-engine/pull/37
Jira issue: https://issues.apache.org/jira/browse/VELOCITY-970
The idea is to remove commons-io from the velocity-engine-core JAR since there does not seem to be a clear reason to do that (it's not like it was the only dependency and commons-io is know to have a pretty good retro compatibility policy). In my case, it also causes problems with a tool in charge of identifying Maven artifacts in the classloader because it also embbed the Maven descriptor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [PR] VELOCITY-970: velocity-engine-core contains commons-io Maven descriptor [velocity-engine]
Posted by "tmortagne (via GitHub)" <gi...@apache.org>.
tmortagne commented on PR #37:
URL: https://github.com/apache/velocity-engine/pull/37#issuecomment-1887573776
OK, this time I saw it I think :)
I'm not 100% sure my modification of maven-bundle-plugin is right, as I'm not used to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [PR] VELOCITY-970: velocity-engine-core contains commons-io Maven descriptor [velocity-engine]
Posted by "tmortagne (via GitHub)" <gi...@apache.org>.
tmortagne commented on PR #37:
URL: https://github.com/apache/velocity-engine/pull/37#issuecomment-1887307090
Hi @michael-o, thanks for taking a look.
I'm sorry, I don't see what you mean. The only reference left to commons-io is [the dependency](https://github.com/tmortagne/velocity-engine/blob/VELOCITY-970/velocity-engine-core/pom.xml#L289) (which strangely was already a transitive dependency, contrary to what's on [maven central for 2.3](https://repo1.maven.org/maven2/org/apache/velocity/velocity-engine-core/2.3/velocity-engine-core-2.3.pom)).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [PR] VELOCITY-970: velocity-engine-core contains commons-io Maven descriptor [velocity-engine]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o closed pull request #37: VELOCITY-970: velocity-engine-core contains commons-io Maven descriptor
URL: https://github.com/apache/velocity-engine/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [PR] VELOCITY-970: velocity-engine-core contains commons-io Maven descriptor [velocity-engine]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #37:
URL: https://github.com/apache/velocity-engine/pull/37#issuecomment-1925425736
Closing this because the Commons IO dependency will be removed after #39 has been merged. Thank you for your effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [PR] VELOCITY-970: velocity-engine-core contains commons-io Maven descriptor [velocity-engine]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #37:
URL: https://github.com/apache/velocity-engine/pull/37#issuecomment-1925446221
Superseded by #40.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org